[18.0][MIG] sale_substate: Migration to 18.0 by Alexgars73 · Pull Request #3581 · OCA/sale-workflow

Alexgars73 · 2025-02-13T07:41:45Z

Migration to 18.0

Depends on:

[ sale_substate][18.0][MIG] base_substate server-ux#1080

dreispt · 2025-04-24T07:29:09Z

@Alexgars73 tests are failing, can you check please?
Also, you could help reviewing the dependency #1050

ellbristow · 2025-05-16T15:35:25Z

sale_substate/views/sale_views.xml

+                    <field
+                        name="substate_id"
+                        widget="statusbar"
+                        options="{'clickable': '1',}"
+                    />


Suggested change

<field

name="substate_id"

widget="statusbar"

options="{'clickable': '1',}"

/>

<field

name="substate_id"

widget="statusbar"

options="{'clickable': '1',}"

domain="[('model', '=', 'sale.order'),('target_state_value_id.target_state_value', '=', state)]"

/>

Filter options down to only valid substates.
Saves clutter and alleviates the need to show an error when the user clicks an invalid substate

@ellbristow Done!.

ellbristow

Functionally tested. LGTM

theangryangel

Functionally tested, LGTM. No longer blocked by dependency.

However, looks like the commits need a tidy?

dreispt · 2025-06-16T16:26:57Z

Great! Please remove the DON'T MERGE commit.

dreispt · 2025-06-16T16:27:28Z

PS: tests are failing, perhaps a rebase can help?

ellbristow · 2025-06-16T16:32:02Z

PS: tests are failing, perhaps a rebase can help?

FYI Failed tests are "Unreleased Dependencies"... Namely base_substate, which was merged 2 days ago

Alexgars73 · 2025-06-17T06:23:26Z

@ellbristow Tests are failing, and I'm not sure why. I rebased, but that didn't fix it. Could you help me? Thanks!

ellbristow · 2025-06-17T06:44:04Z

@Alexgars73 the failing test is not in this module. I don't believe this is related to anything you've done.
I will try to check the other module to see what is causing it to fail

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_substate Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_substate/

Alexgars73 · 2025-07-08T10:53:29Z

@dreispt @ellbristow test resolved!

OCA-git-bot · 2025-07-08T11:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Alexgars73 · 2025-07-16T11:42:43Z

@pedrobaeza could you merge?

pedrobaeza · 2025-07-16T11:43:59Z

Any review from authors, maintainers or PSC is needed.

/ocabot migration sale_substate

ellbristow · 2025-07-16T11:51:26Z

@chafique-delli can you review?
There is no maintainer declared. I'm happy to volunteer as maintainer. I am a paid member

chafique-delli

Code review, LGTM.

Alexgars73 · 2025-07-17T13:42:05Z

@pedrobaeza

@chafique-delli can you review? There is no maintainer declared. I'm happy to volunteer as maintainer. I am a paid member

dreispt · 2025-07-23T08:04:23Z

/ocabot merge nobump

OCA-git-bot · 2025-07-23T08:04:30Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3581-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2025-07-23T08:17:49Z

Congratulations, your PR was merged at 10e9dd1. Thanks a lot for contributing to OCA. ❤️

Alexgars73 changed the title ~~[18.0][MIG] sale_substate~~ [18.0][MIG] sale_substate: Migration to 18.0 Feb 13, 2025

Alexgars73 force-pushed the 18.0-mig-sale_substate branch 2 times, most recently from c44a5bf to 1f6b22e Compare February 25, 2025 10:47

Alexgars73 force-pushed the 18.0-mig-sale_substate branch from 1f6b22e to 2c47da0 Compare March 27, 2025 15:29

Alexgars73 force-pushed the 18.0-mig-sale_substate branch from 2c47da0 to 7eebc4b Compare April 7, 2025 11:04

Alexgars73 force-pushed the 18.0-mig-sale_substate branch 2 times, most recently from 30c8aac to 301c7c8 Compare April 16, 2025 06:55

Alexgars73 force-pushed the 18.0-mig-sale_substate branch 2 times, most recently from 81796cf to 30bc5b8 Compare April 24, 2025 11:38

ellbristow reviewed May 16, 2025

View reviewed changes

Alexgars73 force-pushed the 18.0-mig-sale_substate branch from 30bc5b8 to 085a6eb Compare June 5, 2025 10:52

ellbristow approved these changes Jun 5, 2025

View reviewed changes

dreispt added the blocked by dependency label Jun 6, 2025

theangryangel approved these changes Jun 16, 2025

View reviewed changes

OCA-git-bot added the approved label Jun 16, 2025

Alexgars73 force-pushed the 18.0-mig-sale_substate branch 2 times, most recently from 565adee to 9e4f278 Compare June 17, 2025 06:13

dreispt mentioned this pull request Jun 17, 2025

[18.0][MIG] sale_order_product_availability_inline: Migration to version 18.0 #3576

Merged

dreispt removed the blocked by dependency label Jun 17, 2025

mourad-ehm added 5 commits July 8, 2025 12:46

[ADD] sale_substate 12.0

00fa179

[FIX] base.substate.mixin model name

05e8687

[IMP] add data, demo and tests

d501170

[FIX] pylint, oca_dependency & add readme files

5171ed9

[FIX] pep8

b5b6edf

alexeirivera87 and others added 11 commits July 8, 2025 12:46

[MIG] sale_substate: Migration to 15.0

535d1d2

[MIG] sale_substate: Migration to 16.0

fc5f69d

Added translation using Weblate (Spanish)

22be686

Added translation using Weblate (Italian)

7d13f63

[IMP] sale_substate: apply pre-commit auto fixes

0d5d896

[MIG] sale_substate: Migration to 17.0

9c1864c

[UPD] Update sale_substate.pot

19f8859

[BOT] post-merge updates

55c1424

Update translation files

2fea56a

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_substate Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_substate/

[IMP] sale_substate: pre-commit auto fixes

ef0a381

[MIG] sale_substate: Migration to 18.0

c829ceb

Alexgars73 force-pushed the 18.0-mig-sale_substate branch from 9e4f278 to c829ceb Compare July 8, 2025 10:47

OCA-git-bot added the ready to merge label Jul 8, 2025

OCA-git-bot added this to the 18.0 milestone Jul 16, 2025

OCA-git-bot mentioned this pull request Jul 16, 2025

Migration to version 18.0 #3344

Open

chafique-delli approved these changes Jul 17, 2025

View reviewed changes

dreispt approved these changes Jul 23, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jul 23, 2025

OCA-git-bot merged commit 35aa341 into OCA:18.0 Jul 23, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 23, 2025

Uh oh!

Conversation

Alexgars73 commented Feb 13, 2025 • edited by dreispt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dreispt commented Apr 24, 2025

Uh oh!

ellbristow May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Alexgars73 Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

ellbristow left a comment

Choose a reason for hiding this comment

Uh oh!

theangryangel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dreispt commented Jun 16, 2025

Uh oh!

dreispt commented Jun 16, 2025

Uh oh!

ellbristow commented Jun 16, 2025

Uh oh!

Alexgars73 commented Jun 17, 2025

Uh oh!

ellbristow commented Jun 17, 2025

Uh oh!

Alexgars73 commented Jul 8, 2025

Uh oh!

OCA-git-bot commented Jul 8, 2025

Uh oh!

Alexgars73 commented Jul 16, 2025

Uh oh!

pedrobaeza commented Jul 16, 2025

Uh oh!

ellbristow commented Jul 16, 2025

Uh oh!

chafique-delli left a comment

Choose a reason for hiding this comment

Uh oh!

Alexgars73 commented Jul 17, 2025

Uh oh!

dreispt commented Jul 23, 2025

Uh oh!

OCA-git-bot commented Jul 23, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Jul 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Alexgars73 commented Feb 13, 2025 •

edited by dreispt

Loading

theangryangel left a comment •

edited

Loading