Skip to content

[16.0][ADD] sale_order_country_allowed_product: Restrict products by country in sales#3599

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
sygel-technology:16.0-add-sale_order_country_allowed_product
May 15, 2025
Merged

[16.0][ADD] sale_order_country_allowed_product: Restrict products by country in sales#3599
OCA-git-bot merged 1 commit intoOCA:16.0from
sygel-technology:16.0-add-sale_order_country_allowed_product

Conversation

@manuelregidor
Copy link
Copy Markdown
Contributor

@manuelregidor manuelregidor commented Feb 26, 2025 •
edited
Loading

This module allows to restrict the selection of products in sale order lines based on the shipping address country.

@HaraldPanten @ValentinVinagre @luis-ron

T-6187

luis-ron
luis-ron approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM 👍🏻

@HaraldPanten
Copy link
Copy Markdown
Contributor

HaraldPanten commented Feb 27, 2025

@manuelregidor you should checks tests

@manuelregidor
Copy link
Copy Markdown
Contributor Author

manuelregidor commented Feb 28, 2025

@HaraldPanten There's an incompatibility related to OCA/account-invoicing#1840 that has not been solver yet. There's a PR to solve it which I'm following (#3598).

@HaraldPanten
Copy link
Copy Markdown
Contributor

HaraldPanten commented Feb 28, 2025

Ok, let's wait few days until the related PRs are merged.

Tisho99
Tisho99 suggested changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Tisho99 Tisho99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong module icon

@manuelregidor manuelregidor force-pushed the 16.0-add-sale_order_country_allowed_product branch from f07c99e to e1464e9 Compare February 28, 2025 09:28
@manuelregidor
Copy link
Copy Markdown
Contributor Author

manuelregidor commented Feb 28, 2025

@Tisho99 Changes applied

Tisho99
Tisho99 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Tisho99 Tisho99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Technical review

ValentinVinagre
ValentinVinagre reviewed Feb 28, 2025
View reviewed changes
sale_order_country_allowed_product/security/res_groups.xml
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<odoo>
<record id="ignore_country_sale" model="res.groups">
Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add admin by default

ValentinVinagre
ValentinVinagre reviewed Feb 28, 2025
View reviewed changes
@manuelregidor manuelregidor force-pushed the 16.0-add-sale_order_country_allowed_product branch from e1464e9 to f1e0b89 Compare February 28, 2025 09:42
ValentinVinagre
ValentinVinagre approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@HaraldPanten
Copy link
Copy Markdown
Contributor

HaraldPanten commented Mar 14, 2025

@manuelregidor I'm not sure if other PRs still need to be merged. Have the tests been solved here? Could you rebase?

@manuelregidor
Copy link
Copy Markdown
Contributor Author

manuelregidor commented Mar 17, 2025

@HaraldPanten Still not sorted (#2885)

@manuelregidor manuelregidor force-pushed the 16.0-add-sale_order_country_allowed_product branch from f1e0b89 to 8b8c872 Compare May 7, 2025 06:34
@manuelregidor
Copy link
Copy Markdown
Contributor Author

manuelregidor commented May 7, 2025

@rousseldenis @pedrobaeza Could you have a look? Thank you

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 7, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix
ivs-cetmix requested changes May 11, 2025
View reviewed changes
@manuelregidor manuelregidor force-pushed the 16.0-add-sale_order_country_allowed_product branch from 8b8c872 to c9c1d50 Compare May 13, 2025 11:51
@manuelregidor
Copy link
Copy Markdown
Contributor Author

manuelregidor commented May 13, 2025

@ivs-cetmix Changes done. Could you review? Thank you

ivs-cetmix
ivs-cetmix requested changes May 13, 2025
View reviewed changes
@manuelregidor manuelregidor force-pushed the 16.0-add-sale_order_country_allowed_product branch from c9c1d50 to 9ab04cb Compare May 15, 2025 13:09
@manuelregidor
Copy link
Copy Markdown
Contributor Author

manuelregidor commented May 15, 2025

@ivs-cetmix changes done. Could you review?

ivs-cetmix
ivs-cetmix approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 15, 2025

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3599-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 15, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 15, 2025

Congratulations, your PR was merged at 1fa8265. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 0cb74db into OCA:16.0 May 15, 2025
13 checks passed
@HaraldPanten HaraldPanten deleted the 16.0-add-sale_order_country_allowed_product branch May 16, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

+3 more reviewers

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@Tisho99 Tisho99 Tisho99 approved these changes

@luis-ron luis-ron luis-ron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@manuelregidor @HaraldPanten @OCA-git-bot @ivs-cetmix @ValentinVinagre @Tisho99 @luis-ron