Skip to content

[16.0][MIG] sale_order_note_template#3605

Merged
OCA-git-bot merged 11 commits intoOCA:16.0from
ForgeFlow:16.0-mig-sale_order_note_template
Jun 2, 2025
Merged

[16.0][MIG] sale_order_note_template#3605
OCA-git-bot merged 11 commits intoOCA:16.0from
ForgeFlow:16.0-mig-sale_order_note_template

Conversation

@IsabelAForgeFlow
Copy link
Copy Markdown
Contributor

Supersede: #2612

Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that are not correct IMHO:

  • There is no menu for the T&C Template: you can only create them from the SO. But you can only edit them when the SO is confirmed (because the many2one field becomes not editable and you can go inside to edit it)
  • The archive wizard is not good:
    image

Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code + Functional

@sebalix
Copy link
Copy Markdown
Contributor

sebalix commented Mar 10, 2025

/ocabot migration sale_order_note_template

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 10, 2025
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Copy Markdown
Member

dreispt commented Mar 30, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3605-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 30, 2025
Signed-off-by dreispt
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3605-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3605-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 341ac19 into OCA:16.0 Jun 2, 2025
6 of 9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 07263f3. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-mig-sale_order_note_template branch June 2, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants