Skip to content

[18.0][MIG] sale_order_qty_change_no_recompute: Migration to 18.0#3617

Closed
psugne wants to merge 16 commits intoOCA:18.0from
versada:18.0-mig-sale_order_qty_change_no_recompute
Closed

[18.0][MIG] sale_order_qty_change_no_recompute: Migration to 18.0#3617
psugne wants to merge 16 commits intoOCA:18.0from
versada:18.0-mig-sale_order_qty_change_no_recompute

Conversation

@psugne
Copy link
Copy Markdown

@psugne psugne commented Mar 10, 2025

No description provided.

victoralmau and others added 16 commits March 10, 2025 16:12
…hange

The _origin trick is not valid, as it doesn't reflect the state before
the onchange, only the saved copy (if any).
…ent onchange quantity and some possible related error in another addons.
Changing that field shouldn't trigger price recomputation as well.

TT32663
- Standard procedure
- Change the strategy, as now the change is done through a computed
  field.
- Improved README
Copy link
Copy Markdown
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psugne are you still working on this?

Some of the commits can be squashed and the pre-commit commit is not correctly named:
image

Also some unit tests are failing

from odoo.tests.common import TransactionCase


class TestSaleOrderQtyChange(TransactionCase):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use BaseCommon as base test class to reduce overhead from tracking and boost the test suite.

@pedrobaeza
Copy link
Copy Markdown
Member

It seems the module is no longer needed: OCA/OpenUpgrade#4870

@CRogos
Copy link
Copy Markdown
Contributor

CRogos commented Mar 24, 2025

Totally agree with @pedrobaeza
Just followed these instructions and the price was not reset without this module.

To use this module, you need to:

1.  Create a new sale order.
2.  Add product line and set custom unit price.
3.  Save sale order.
4.  Edit sale order and change quantity (custom unit price not been
    reset).

=> close

@psugne
Copy link
Copy Markdown
Author

psugne commented Mar 24, 2025

Closing PR as sale_order_qty_change_no_recompute module is no longer needed.

@psugne psugne closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants