[18.0][MIG] sale_order_priority: Migration to 18.0

[apami0111]

• Migrated from 17.0 to 18.0.
• Updated xpath expression in the view to reflect Odoo 18.0 changes (//list instead of //tree).
• Test class now uses Command.create to define order_line values, in line with Odoo 18.0 conventions.

[rousseldenis]

/ocabot migration sale_order_priority

[apami0111]

Thank you very much for your comment. I will be working on the suggested changes and will update the PR accordingly. El vie, 4 jul 2025 a las 9:54, Denis Roussel (ACSONE) (< ***@***.***>) escribió:

…

***@***.**** requested changes on this pull request. ------------------------------ In sale_order_priority/__manifest__.py <#3786 (comment)>: > @@ -3,7 +3,7 @@ { "name": "Sale Order Priority", "summary": "Define priority on sale orders", - "version": "17.0.1.0.1", + "version": "18.0.1.0.1", Please reset to 18.0.1.0.0 ------------------------------ In sale_order_priority/models/sale.py <#3786 (comment)>: > + @api.depends("order_line.priority") + def _compute_priority(self): + for order in self.filtered(lambda x: x.order_line): + priority = order.mapped("order_line.priority") + order.priority = max([x for x in priority if x] or "0") + + def _inverse_priority(self): + for order in self: + priority = order.priority + for line in order.order_line.filtered( + lambda x, pr=priority: x.priority != pr + ): + line.priority = priority + + def action_confirm(self): + return super( This is not correct as self can be multi recordset. Moreover, I think the transmission of the priority should be done through procurement if possible as context should be avoided. — Reply to this email directly, view it on GitHub <#3786 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKVNRJ3QUYCLX6VP2YT44433G2IT3AVCNFSM6AAAAACAUN623OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOBXGUYTEOJQGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[apami0111]

@rousseldenis Thanks for your feedback! I've addressed the issue with the multi-recordset by adjusting the logic accordingly. I’ve also reworked the way priority is transmitted, avoiding the use of context as suggested.

The following structural changes were made as well:

• Renamed: sale_order_priority/models/{sale.py => sale_order.py}
• Created: sale_order_priority/models/sale_order_line.py
• Created: sale_order_priority/models/stock_move.py
• Removed: sale_order_priority/models/stock_picking.py

Feel free to review the updated implementation. Let me know if anything else needs to be improved.

[celm1990]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[marcelsavegnago]

LGTM

[BhaveshHeliconia]

Functional review LGTM!

[rousseldenis]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3786-by-rousseldenis-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 71bba56. Thanks a lot for contributing to OCA. ❤️