[18.0][MIG] sale_order_line_input: Migration to 18.0 by victoralmau · Pull Request #3795 · OCA/sale-workflow

victoralmau · 2025-07-07T10:05:47Z

Supersedes #3458

Changes done:

Purge translations
Squash administrative commits
[18.0][MIG] sale_order_line_input: Migration to 18.0 #3458 (review)
Use BaseCommon in tests
Remove invisible fields (according to the migration guide they are not needed, odoo will auto-add them if needed).

Migration to 18.0

Please @carlosdauden and @pedrobaeza can you review it?

@Tecnativa TT54282

pedrobaeza · 2025-07-08T07:14:06Z

/ocabot migration sale_order_line_input

sale_order_line_input/models/sale_order.py

carlosdauden · 2025-07-08T17:51:52Z

sale_order_line_input/views/sale_order_line_view.xml

+                <field
+                    name="product_id"
+                    readonly="not product_updatable"
+                    required="not display_type"


This is something I have to comment on every migration...
The objective of this module is to manage the order lines from a tree view, but keeping as much as possible the behaviour they have in the normal order view.
To do this, what you have to do in the migration of this module is to go to compare the order view and put the same fields with the same attributes (except the conditions in which ‘parent.’ is used).

This is just an example of the attributes that have not been checked, but there are others like with, string, etc. that are not seen here either:
https://github.com/odoo/odoo/blob/c84b67e5dca1a74e1a5862e754455944015f4105/addons/sale/views/sale_order_views.xml#L531

Ok, “copied” the sale view in this module; I don't like this technique because for example many things will not work the same (sections, notes, sequences) in addition to the changes that other modules make in the sales order lines in the form view (add an extra column for example). It could also be the case (with other OCA modules that extend sales) that in order to create new lines, fields that are not in the view are required and/or need to be defined.

The sol_product_many2one widget is not supported outside the order form view, therefore the product_id field is always shown and the product_template_id field is hidden.

2 extra fields have been added:

company_price_amount: They replace the price_subtotal + price_total fields because it is not possible to make column_invisible with conditional and also because it will not always be the same value (if we are showing lines from different companies and each one has a defined configuration). https://github.com/odoo/odoo/blob/a7a29ed691db4f1607c0d12929c56845681164fa/addons/sale/views/sale_order_views.xml#L657

company_price_tax_incl_excl: Replaces the fields (Optional amounts) price_total + price_subtotal for the same reason as above. https://github.com/odoo/odoo/blob/a7a29ed691db4f1607c0d12929c56845681164fa/addons/sale/views/sale_order_views.xml#L666

[UPD] README.rst [UPD] Update sale_order_line_input.pot

[UPD] Update sale_order_line_input.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_input/

[UPD] README.rst

Currently translated at 100.0% (17 of 17 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_input/zh_CN/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_input/

[UPD] Update sale_order_line_input.pot [UPD] README.rst

to solve a pypi upload issue

Since v13 the customer field on res.partner model has been disappeared, so when we try to add a value on the field order_partner_id we get an error. sale_order_line_input 13.0.1.1.0

…any domains don't work. Taxes empty

[MIG] sale_order_line_input: Migration to 14.0

[UPD] Update sale_order_line_input.pot [UPD] README.rst [IMP] update dotfiles [ci skip] [UPD] README.rst [UPD] README.rst

TT36521

…d to show order from order line

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_input/it/

[UPD] Update sale_order_line_input.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_order_line_input/

Currently translated at 100.0% (18 of 18 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_order_line_input/it/ Translated using Weblate (Italian) Currently translated at 100.0% (18 of 18 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_order_line_input/it/

Translated using Weblate (Turkish) Currently translated at 100.0% (18 of 18 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_order_line_input/tr/

TT54282 Co-authored-by: Raura <jcolljeyce@gmail.com>

victoralmau · 2025-07-09T10:42:38Z

Ping @CarlosRoca13

carlosdauden

Great work.

I think it is better not to create those additional fields to show the amounts with and without tax.

On the one hand we can cause confusion to the user when viewing records of several companies with different configuration and in the same column some amounts are with taxes and others without taxes.
On the other hand, we increase the complexity of the module in an ‘unnecessary’ way, as I think that one option would be to add all the fields in the view so that the user can manage them as he/she sees fit.

We can put optional=‘show’ for the fields without taxes and optional=‘hide’ for the fields with taxes and this way we are coherent with the default values that Odoo brings regarding this configuration.

carlosdauden

Sorry, I understand that the use of the additional fields does not cause confusion

pedrobaeza · 2025-07-11T11:33:29Z

/ocabot merge nobump

OCA-git-bot · 2025-07-11T11:33:37Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3795-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-07-11T11:46:36Z

Congratulations, your PR was merged at 43f33c4. Thanks a lot for contributing to OCA. ❤️

victoralmau mentioned this pull request Jul 7, 2025

[18.0][MIG] sale_order_line_input: Migration to 18.0 #3458

Closed

OCA-git-bot added this to the 18.0 milestone Jul 8, 2025

OCA-git-bot mentioned this pull request Jul 8, 2025

Migration to version 18.0 #3344

Open

pedrobaeza reviewed Jul 8, 2025

View reviewed changes

sale_order_line_input/models/sale_order.py Outdated Show resolved Hide resolved

pedrobaeza approved these changes Jul 8, 2025

View reviewed changes

pedrobaeza requested a review from carlosdauden July 8, 2025 07:47

carlosdauden suggested changes Jul 8, 2025

View reviewed changes

carlosdauden and others added 22 commits July 9, 2025 08:13

[ADD] sale_order_line_input: New module

5674487

[UPD] README.rst [UPD] Update sale_order_line_input.pot

[MIG] sale_order_line_input: migration to v12.0

02ef7bc

Added translation using Weblate (German)

de4c781

[UPD] README.rst

[IMP] sale_order_line_input: black, isort, prettier

d5e8957

[MIG] sale_order_line_input: Migration to 13.0

d90b4d7

[UPD] Update sale_order_line_input.pot [UPD] README.rst

[FIX] sale_order_line_input: bump version

33e935a

to solve a pypi upload issue

[FIX] sale_order_line_input: The field customer does not exist

4d85a90

Since v13 the customer field on res.partner model has been disappeared, so when we try to add a value on the field order_partner_id we get an error. sale_order_line_input 13.0.1.1.0

[FIX] sale_order_line_input: company_id field is empty and multi-comp…

03d3255

…any domains don't work. Taxes empty

[MIG] sale_order_line_input: Migration to 14.0

2efceb9

[MIG] sale_order_line_input: Migration to 14.0

IMP sale_order_line_input: add write_date on view

c6c4caa

[UPD] Update sale_order_line_input.pot [UPD] README.rst [IMP] update dotfiles [ci skip] [UPD] README.rst [UPD] README.rst

[MIG] sale_order_line_input: Migration to 15.0

c999ada

TT36521

[FIX] sale_order_line_input: Administration/Settings group is require…

0657abd

…d to show order from order line

[MIG] sale_order_line_input: Migration to 16.0

a8ae977

Translated using Weblate (Italian)

a8a4051

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_input/it/

[IMP] sale_order_line_input: pre-commit auto fixes

e03493f

[IMP] sale_order_line_input: pre-commit auto fixes

065c06b

[MIG] sale_order_line_input: Migration to 18.0

e837394

TT54282 Co-authored-by: Raura <jcolljeyce@gmail.com>

victoralmau force-pushed the 18.0-mig-sale_order_line_input branch from 9e9aa83 to e837394 Compare July 9, 2025 10:30

carlosdauden suggested changes Jul 11, 2025

View reviewed changes

carlosdauden approved these changes Jul 11, 2025

View reviewed changes

OCA-git-bot added the approved label Jul 11, 2025

OCA-git-bot added the bot is merging ⏳ label Jul 11, 2025

OCA-git-bot merged commit 20411d1 into OCA:18.0 Jul 11, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 11, 2025

pedrobaeza deleted the 18.0-mig-sale_order_line_input branch July 11, 2025 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0][MIG] sale_order_line_input: Migration to 18.0#3795

[18.0][MIG] sale_order_line_input: Migration to 18.0#3795
OCA-git-bot merged 22 commits intoOCA:18.0from
Tecnativa:18.0-mig-sale_order_line_input

victoralmau commented Jul 7, 2025 •

edited

Loading

Uh oh!

pedrobaeza commented Jul 8, 2025

Uh oh!

Uh oh!

carlosdauden Jul 8, 2025

Uh oh!

victoralmau Jul 9, 2025

Uh oh!

victoralmau commented Jul 9, 2025

Uh oh!

carlosdauden left a comment

Uh oh!

carlosdauden left a comment

Uh oh!

pedrobaeza commented Jul 11, 2025

Uh oh!

OCA-git-bot commented Jul 11, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Conversation

victoralmau commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Jul 8, 2025

Uh oh!

Uh oh!

carlosdauden Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

victoralmau Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

victoralmau commented Jul 9, 2025

Uh oh!

carlosdauden left a comment

Choose a reason for hiding this comment

Uh oh!

carlosdauden left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jul 11, 2025

Uh oh!

OCA-git-bot commented Jul 11, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

victoralmau commented Jul 7, 2025 •

edited

Loading