[16.0][IMP] sale_order_safe_commitment_date: fill delivery date#3820
Merged
OCA-git-bot merged 2 commits intoOCA:16.0from Jul 22, 2025
Merged
Conversation
The delivery date is computed by default from the expected date. We can still edit it, but if can't be delivered, it will be force on confirmation. MT-9790
Contributor
|
Hi @rafaelbn, |
EmilioPascual
approved these changes
Jul 21, 2025
Contributor
EmilioPascual
left a comment
EmilioPascual
left a comment
There was a problem hiding this comment.
Functional and code review
https://www.loom.com/share/0804b4a5f18842caa0ef0863ba1bf4ab?sid=1f53f8aa-7372-480e-ae46-78d500e7eda9
sale_order_safe_commitment_date breaks test of other modules, so it's better split to it @moduon MT-9790
EmilioPascual
force-pushed
the
16.0-imp-sale_order_safe_commitment_date-delivery_date
branch
from
1094064 to
eca8ba3
Compare
rafaelbn
approved these changes
Jul 22, 2025
Member
rafaelbn
left a comment
rafaelbn
left a comment
There was a problem hiding this comment.
Thank you!
Reviewed, this improvement will help a lot! 👍🏼 😄
Member
|
/ocabot merge minor |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at a592007. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delivery date is computed by default from the expected date. We can still edit it, but if can't be delivered, it will be force on confirmation.
cc @moduon @rafaelbn @Gelojr @Shide MT-9790