Skip to content

[17.0] [MIG] sale_attached_product: Migration to 17.0#3822

Merged
OCA-git-bot merged 11 commits intoOCA:17.0from
bizzappdev:17.0-mig-sale_attached_product-BAD
Aug 20, 2025
Merged

[17.0] [MIG] sale_attached_product: Migration to 17.0#3822
OCA-git-bot merged 11 commits intoOCA:17.0from
bizzappdev:17.0-mig-sale_attached_product-BAD

Conversation

@bizzappdev
Copy link
Copy Markdown
Contributor

No description provided.

@bizzappdev bizzappdev marked this pull request as ready for review July 18, 2025 05:53
@rousseldenis
Copy link
Copy Markdown
Contributor

/ocabot migration sale_attached_product

widget="many2many_tags"
options="{'color_field': 'color'}"
domain="[('id', '!=', active_id), '|', ('company_id', '=', company_id), ('company_id', '=', False)]"
domain="[('id', '!=', id), '|', ('company_id', '=', company_id), ('company_id', '=', False)]"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[('id', '!=', id), ('company_id', 'in', [company_id, False]),] is better in terms of performance

@bizzappdev bizzappdev force-pushed the 17.0-mig-sale_attached_product-BAD branch from 26ba5e4 to 826295e Compare July 18, 2025 07:10
@bizzappdev bizzappdev requested a review from rousseldenis July 18, 2025 07:18
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-3822-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 34e4d67 into OCA:17.0 Aug 20, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f514652. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.