[18.0][IMP] sale_elaboration: elaboration profile from product category#3857
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Aug 13, 2025
Merged
Conversation
Elaboration profiles can now be set from the category so if no profile is set in the product it defaults to that one. TODO: - `test.Form` doesn't constrain the view domain for profiles... so the only way to test the flow would be either to use a helper domain field or a tour... Some tooling left in the test case anyway. MT-10786 Co-authored-by: David Vidal <david@moduon.team>
Contributor
|
Hi @CarlosRoca13, @rafaelbn, @yajo, @sergio-teruel, |
rafaelbn
approved these changes
Aug 11, 2025
Member
rafaelbn
left a comment
rafaelbn
left a comment
There was a problem hiding this comment.
Tested in runbot 👍🏼 , tested as 16 (already merged) and 17
fcvalgar
approved these changes
Aug 12, 2025
fcvalgar
left a comment
fcvalgar
left a comment
There was a problem hiding this comment.
Functional review,
LGTM, thank you @chienandalu .
Member
|
/ocabot migration sale_elaboration |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at cae7753. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fw of
Elaboration profiles can now be set from the category so if no profile is set in the product it defaults to that one.
TODO:
test.Formdoesn't constrain the view domain for profiles... so the only way to test the flow would be either to use a helper domain field or a tour... Some tooling left in the test case anyway.cc @moduon MT-10786
please review if you feel like it 🙂 @rafaelbn @sergio-teruel @Andrii9090