[15.0][ADD] sale_stock_warehouse_partner: New module#3916
[15.0][ADD] sale_stock_warehouse_partner: New module#3916OCA-git-bot merged 1 commit intoOCA:15.0from
Conversation
eduezerouali-tecnativa
force-pushed
the
15.0-add-sale_stock_warehouse_partner
branch
2 times, most recently
from
3088ac0 to
5cb5624
Compare
| sale_order_type_module = self.env["ir.module.module"].search( | ||
| [("name", "=", "sale_order_type")] | ||
| ) | ||
| if sale_order_type_module or sale_order_type_module.state == "installed": |
There was a problem hiding this comment.
Use registry instead of search to minimize DB calls.
| sale_order_type_module = self.env["ir.module.module"].search( | |
| [("name", "=", "sale_order_type")] | |
| ) | |
| if sale_order_type_module or sale_order_type_module.state == "installed": | |
| if "sale_order_type" in self.env.registry._init_modules and "sale_stock_warehouse_order_type" not in self.env.registry._init_modules: |
There was a problem hiding this comment.
No longer that need it, but good to know.
eduezerouali-tecnativa
force-pushed
the
15.0-add-sale_stock_warehouse_partner
branch
3 times, most recently
from
a33d00c to
0bf64ef
Compare
eduezerouali-tecnativa
force-pushed
the
15.0-add-sale_stock_warehouse_partner
branch
2 times, most recently
from
514a629 to
27dddc3
Compare
| class ResPartner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| warehouse_id = fields.Many2one( |
There was a problem hiding this comment.
This should be company dependent IMHO
There was a problem hiding this comment.
@eduezerouali-tecnativa Can you attend this comment?? Thanks..
There was a problem hiding this comment.
@rousseldenis You're right, makes it more flexible for multi-company scenario. Changes done. Thanks!
There was a problem hiding this comment.
One more thing, could you change the field name like sale_warehouse_id ? Thanks
There was a problem hiding this comment.
Here, not on sale.order level 😅
eduezerouali-tecnativa
force-pushed
the
15.0-add-sale_stock_warehouse_partner
branch
2 times, most recently
from
a34f6fd to
63c5841
Compare
| comodel_name="stock.warehouse", | ||
| company_dependent=True, | ||
| string="Warehouse", | ||
| help="Set deafult warehouse for Sale Order", |
There was a problem hiding this comment.
| help="Set deafult warehouse for Sale Order", | |
| help="Set default warehouse for Sale Order", |
eduezerouali-tecnativa
force-pushed
the
15.0-add-sale_stock_warehouse_partner
branch
5 times, most recently
from
2e5bf47 to
09cd558
Compare
eduezerouali-tecnativa
force-pushed
the
15.0-add-sale_stock_warehouse_partner
branch
from
09cd558 to
a59b876
Compare
|
@rousseldenis changes done, could you review please. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 5d8188f. Thanks a lot for contributing to OCA. ❤️ |
6 participants
cc @Tecnativa TT58152
ping @sergio-teruel @carlosdauden