[19.0][MIG] sale_product_set: Migration to 19.0

[mmrondon]

No description provided.

[rousseldenis]

/ocabot migration sale_product_set

[rousseldenis]

@mmrondon Thanks for this.

Could you put in this' description the libnk to the depending PR (product_set)?

Moreover, you can embed it too here in order to test it thourgh runboat and make tests running following https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

[mmrondon]

Dependency PR: OCA/product-attribute#2098

[rousseldenis]

An idea is to no more use odoo-test-helper but I'm not sure we can remove it yet. See: OCA/server-tools#3417 (comment)

[alexey-pelykh]

Review: [19.0][MIG] sale_product_set

Thank you for working on this migration. I reviewed the full module code on the branch (Python models, wizard, views, tests, security, demo data) against Odoo 19.0 requirements and OCA conventions. Below are the findings.

---

Critical: All CI Checks Failing

All four CI checks are red:

• pre-commit: FAILED
• test with Odoo: FAILED
• test with OCB: FAILED
• Detect unreleased dependencies: FAILED

These must all pass before the PR can be merged.

---

Critical: Unreleased Dependency product_set

The __manifest__.py declares "depends": ["sale", "sale_management", "product_set"]. The product_set module lives in OCA/product-attribute and has not been merged to the 19.0 branch yet. There is an open migration PR (OCA/product-attribute#2098) but it also has CI failures.

This is the root cause of the "Detect unreleased dependencies" failure and likely cascades into the test failures (module cannot be installed).

Action needed: Coordinate with OCA/product-attribute#2098 to get product_set merged first, or at minimum ensure both PRs are CI-green so they can land together.

---

Migration Completeness: Version Bump Only

Comparing the PR branch content to 18.0, the only change is the version bump in __manifest__.py (18.0.1.0.0 → 19.0.1.0.0). No code was adapted for Odoo 19.0 API changes.

While a clean version bump is valid when the upstream API hasn't changed, the following items should be explicitly verified against Odoo 19.0 (and may require adaptation):

1. Test Demo Data Reference: sale.sale_order_6

The test file (tests/test_product_set.py) uses:

cls.so = cls.env.ref("sale.sale_order_6")

Odoo periodically restructures demo/test data across versions. If sale.sale_order_6 was removed or renamed in 19.0, all tests will fail at setUpClass. Other working 19.0 modules in this repo create sale orders programmatically in setUpClass rather than relying on external demo refs. Please verify this reference exists in Odoo 19.0, or refactor the test setup to create orders programmatically.

2. Sale Order View XPath: action_add_from_catalog

In views/sale_order.xml, the view inherits sale.view_order_form and targets:

<xpath expr="//button[@name='action_add_from_catalog']" position="before">

If this button was renamed, moved, or removed in Odoo 19.0, the view will fail to load. Please verify this XPath target against the Odoo 19.0 sale order form view.

3. Domain Expression: parent.state

The same view uses:

invisible="parent.state not in ['draft', 'sent']"

While draft and sent states exist in Odoo 17/18/19, the parent. prefix syntax for accessing parent model fields in embedded views should be verified for 19.0. Some Odoo versions changed domain evaluation behavior.

4. product_uom_id Field in prepare_sale_order_line_values

In models/product_set_line.py:

"product_uom_id": self.product_id.uom_id.id,

Odoo has renamed product_uom to product_uom_id at different points. Please verify the sale order line model field name in 19.0.

5. self.env._() Usage

The wizard uses self.env._("...") for translations, which is the correct pattern for Odoo 17+. This is fine.

---

Minor: Pre-commit Failures

The pre-commit check is failing. Common causes for migration PRs:

• Missing newline at end of file
• Trailing whitespace
• Import ordering
• OCA linting rules

Please run pre-commit run --all-files locally and fix any issues.

---

Summary

Item	Severity	Status
CI all red (4/4 failing)	Blocker	Must fix
product_set dependency not on 19.0	Blocker	Coordinate with product-attribute#2098
sale.sale_order_6 test ref	Likely blocker	Verify or refactor
action_add_from_catalog XPath	Needs verification	May break view loading
parent.state domain syntax	Needs verification	May break view loading
product_uom_id field name	Needs verification	May break SO line creation
pre-commit failures	Must fix	Run locally

Once the product_set dependency is available on 19.0 and CI can actually install the module, the test/view issues above should become visible. I recommend:

1. Coordinate with product-attribute#2098 first
2. Fix pre-commit issues locally
3. Verify all Odoo 19.0 API items listed above
4. Push fixes and confirm CI goes green

[MohamedOsman7]

@mmrondon please check #3941 (review)