[19.0][MIG] sale_delivery_split_date: Migration to 19.0 by Tatider · Pull Request #3948 · OCA/sale-workflow

Tatider · 2025-10-15T14:04:38Z

An update of tests was required because in Odoo 19.0, the database by default doesn't have Demo Data.

Depends on:

rousseldenis · 2025-10-18T09:30:34Z

/ocabot migration sale_delivery_split_date

yankinmax · 2025-12-09T08:09:30Z

 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>Sale Delivery Split Date</title>


Is this change generated by pre-commit? Strange change to <title>README.rst</title>

Yes, it is precommit doing the change...

yankinmax

pre-approve considering a question

Tatider · 2025-12-09T13:56:40Z

One of the dependencies to be renamed, waiting for the final name to be defined - "#3947"

Tatider · 2025-12-18T09:34:01Z

One of the dependencies to be renamed, waiting for the final name to be defined - "#3947"

Updated

ivantodorovich

small comment, non blocking

ivantodorovich · 2025-12-22T13:38:32Z

            if self.commitment_date:
                comm_date = self._get_security_lead_time_commitment_date()
-                vals["name"] += "/" + format_date(self.env, comm_date.date())
+                vals["name"] = (


Maybe it's just me, but I found it was more readable before.
Why this change? it doesn't seem like an useful diff

To my understanding, usage of "+=" for strings is considered a bad practice, bacause it might lead to unxpected errors when one of arguments is not a string, f.e. "False" as it might be with Sale Line Name

* [ADD] sale_delivery_split_date module * [ADD] sale_delivery_split_date: add computed min_dt to allow deliveries to be searchable by the scheduled date

…ME file

Note that sale_delivery_split_date is not compatible with sale_procurement_group_by_commitment_date

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_delivery_split_date/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_delivery_split_date/

Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_delivery_split_date/it/

yaracchi · 2026-01-23T08:49:30Z

Are the 2 failing checks blocking or this can be used?

Tatider · 2026-01-27T07:44:10Z

Are the 2 failing checks blocking or this can be used?

It could be used. Warnings were about test coverage and the old status of dependencies.
Anyway, all is resolved now.

OCA-git-bot · 2026-01-27T07:45:28Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

yankinmax · 2026-01-27T07:46:29Z

Hello @rousseldenis can this PR be merged now? All suggestions are taken into account.

imlopes · 2026-02-23T14:52:24Z

Hello @OCA/crm-sales-marketing-maintainers

Could you check and merge this PR ?
It seems all comments are fixed and it's ready.

Thanks a lot

alexey-pelykh

Thorough migration from 18.0 to 19.0. The module correctly adapts to the renamed dependency (sale_procurement_group_by_line -> sale_stock_reference_by_line) and the new stock.reference model API. Both dependency PRs (#3946, #3947) are merged. CI is fully green.

Key migration changes reviewed:

Dependency update -- sale_procurement_group_by_line renamed to sale_stock_reference_by_line with comment # ex. sale_procurement_group_by_line for traceability. Good.
API adaptation -- _prepare_procurement_group_vals() correctly renamed to _prepare_reference_vals() to match the new base module API. The string concatenation refactored from vals["name"] += to explicit vals.get("name", "") + ... -- reasonable defensive approach as discussed in prior review comments.
_prepare_procurement_values -- Method signature correctly drops the group_id parameter to match the 19.0 base. The walrus operator usage (if line_com_date := self.commitment_date:) is clean and was already reviewed/approved. The addition of date_deadline=line_com_date alongside date_planned is a welcome improvement to propagate the commitment date as the move deadline.
Tests -- Properly adapted from TransactionCase to TestSaleStockCommon to avoid demo data dependency (which Odoo 19.0 no longer provides by default). All procurement_group_id references updated to stock_reference_id. New test_wo_a_date test covers the no-commitment-date edge case. The test_check_same_dates and security lead time tests now also verify date_deadline on stock moves -- good additional coverage.
Views -- stock_picking.xml unchanged from 18.0 logic, makes scheduled_date visible in tree and searchable. Standard OCA pattern.

No blocking issues found. LGTM.

paulius-sladkevicius

LGTM

yankinmax · 2026-03-12T11:38:22Z

Hello @OCA/crm-sales-marketing-maintainers

Could you check and merge this PR ?

yankinmax · 2026-03-16T12:38:53Z

Hello @rousseldenis can you pls merge this PR?

rousseldenis · 2026-03-26T09:19:25Z

/ocabot merge nobump

OCA-git-bot · 2026-03-26T09:19:35Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-3948-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2026-03-26T09:27:11Z

Congratulations, your PR was merged at c31ef91. Thanks a lot for contributing to OCA. ❤️

This was referenced Oct 15, 2025

[MIG][19.0] sale_order_line_date, sale_procurement_group_by_line, sale_delivery_split_date: Migration to 19 #3931

Closed

Migration to version 19.0 #3914

Open

OCA-git-bot added this to the 19.0 milestone Oct 18, 2025

yankinmax reviewed Dec 9, 2025

View reviewed changes

Comment thread sale_delivery_split_date/models/sale_order_line.py

yankinmax reviewed Dec 9, 2025

View reviewed changes

yankinmax approved these changes Dec 9, 2025

View reviewed changes

Tatider force-pushed the 19.0-mig-sale-delivery-split-date branch from dfe8fef to 9bebdaf Compare December 9, 2025 13:56

Tatider force-pushed the 19.0-mig-sale-delivery-split-date branch from 9bebdaf to 99c6967 Compare December 18, 2025 09:31

ivantodorovich approved these changes Dec 22, 2025

View reviewed changes

OCA-git-bot added the approved label Dec 22, 2025

tafaRU and others added 17 commits January 21, 2026 08:40

[8.0][ADD] sale_delivery_split_date module (OCA#620)

2db4b13

* [ADD] sale_delivery_split_date module * [ADD] sale_delivery_split_date: add computed min_dt to allow deliveries to be searchable by the scheduled date

[MIG] sale_delivery_split_date: Migration to 10.0

a2834a7

[FIX] sale_delivery_split_date: fix incompatible modules urls in READ…

bc2cf8d

…ME file

[MIG] sale_delivery_split_date: Migration to 12.0

3fc57bd

Note that sale_delivery_split_date is not compatible with sale_procurement_group_by_commitment_date

Added translation using Weblate (Catalan)

1827026

Added translation using Weblate (Spanish)

c38f469

Added translation using Weblate (Portuguese (Portugal))

7601e13

[IMP] sale_delivery_split_date: black, isort, prettier

30efbb1

[MIG] sale_delivery_split_date: Migration to 14.0

c89afcc

[MIG] sale_delivery_split_date: Migration to 15.0

63db4ec

[MIG] sale_delivery_split_date: Migration to 16.0

8c8d382

[IMP] sale_delivery_split_date: use security lead time

c83337d

[IMP] sale_delivery_split_date: pre-commit stuff

62f199d

[MIG] sale_delivery_split_date: Migration to 17.0

d2e01d0

oca-ci and others added 6 commits January 21, 2026 08:40

[UPD] Update sale_delivery_split_date.pot

3e0015a

[BOT] post-merge updates

90442aa

[IMP] sale_delivery_split_date: pre-commit auto fixes

f8d1425

[MIG] sale_delivery_split_date: Migration to 18.0

0833027

[UPD] Update sale_delivery_split_date.pot

9aa43bc

[BOT] post-merge updates

f448433

Tatider force-pushed the 19.0-mig-sale-delivery-split-date branch from 99c6967 to d2b71a9 Compare January 21, 2026 06:43

[MIG] sale_delivery_split_date: Migrate to 19.0

b251c21

Tatider force-pushed the 19.0-mig-sale-delivery-split-date branch from d2b71a9 to b251c21 Compare January 27, 2026 07:37

OCA-git-bot added the ready to merge label Jan 27, 2026

gediminasvenc added a commit to linserv/sale-workflow that referenced this pull request Feb 12, 2026

[MIG] sale_delivery_split_date: from PR OCA#3948

31bcdee

alexey-pelykh approved these changes Mar 1, 2026

View reviewed changes

paulius-sladkevicius approved these changes Mar 3, 2026

View reviewed changes

rousseldenis approved these changes Mar 26, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 26, 2026

OCA-git-bot merged commit 7a9d30e into OCA:19.0 Mar 26, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 26, 2026

Uh oh!

Conversation

Tatider commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rousseldenis commented Oct 18, 2025

Uh oh!

Uh oh!

yankinmax Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Tatider Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

yankinmax left a comment

Choose a reason for hiding this comment

Uh oh!

Tatider commented Dec 9, 2025

Uh oh!

Tatider commented Dec 18, 2025

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Tatider Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

yaracchi commented Jan 23, 2026

Uh oh!

Tatider commented Jan 27, 2026

Uh oh!

OCA-git-bot commented Jan 27, 2026

Uh oh!

yankinmax commented Jan 27, 2026

Uh oh!

imlopes commented Feb 23, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

paulius-sladkevicius left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Mar 12, 2026

Uh oh!

yankinmax commented Mar 16, 2026

Uh oh!

rousseldenis commented Mar 26, 2026

Uh oh!

OCA-git-bot commented Mar 26, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Tatider commented Oct 15, 2025 •

edited

Loading