[19.0][MIG] sale_triple_discount: Migration to 19.0 by lef-adhoc · Pull Request #3965 · OCA/sale-workflow

lef-adhoc · 2025-10-23T14:54:55Z

Based on this pr: #3889

Depends on:

[19.0][MIG] account_invoice_triple_discount: Migration to 19.0 account-invoicing#2144

ferran-S73

Code review

lef-adhoc · 2025-10-31T15:17:05Z

@sbejaoui Hi, could you check this PR?

OCA Transbot updated translations from Transifex [UPD] Update sale_triple_discount.pot

Currently translated at 100,0% (5 of 5 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/nl_NL/

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/nl_NL/

…ly configuration

…onsistency [FIX] sale_triple_discount: Invalidating the cache of specific records before recomputing price and discount [UPD] Update sale_triple_discount.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/

…3 in the computation

[UPD] Update sale_triple_discount.pot

[UPD] Update sale_triple_discount.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_triple_discount/

[UPD] Update sale_triple_discount.pot [UPD] README.rst

Currently translated at 100.0% (11 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_triple_discount/it/ [UPD] README.rst [UPD] README.rst

Currently translated at 0.0% (0 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_triple_discount/fr/

[UPD] Update sale_triple_discount.pot [UPD] README.rst

Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/it/

Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/de/

Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/pt_BR/

Method 'invalidate_cache' is deprecated. To invalidate specific field's value into the cache for a recordset we must use the 'invalidate_recordset' method on the recordset itself.

When computing the amount total on a sale.order.line, we now avoid to play with the cache since this change introduced in OCA@e3e59ba introduces a decline in performance. When the cache in invalidated, fields are flushed to the database and depending computed fields are recomputed..... This ultimately leads to temporary inconsistencies breaking others addons relaying on this one. Moreover, the method used in this original commit 'self.invalidate_cache(fnames=self._discount_fields(), ids=self.ids)' is deprecated and the use of the recommended new one lead to others side effects. The original approach is replaced by a contextual method modifying only the discount field when we need it's needed to don't break code relaying on the fact that the discount field is the total discount to apply to a line. This contextual method ensures that the original value is properly restored on exit and that it will not trigger additional recompute due to the temporary change of the discount value

inspired by OCA/account-invoicing#1638

see OCA#3649

add an inverse to the standard discount field, which resets the three discounts and sets discount1 with the value coming from the inverse. this way, any standard process like pricelists will integrate with this logic out of the box, without extra customization

…er lines

dreispt · 2026-01-04T17:40:33Z

/ocabot migration sale_triple_discount

Reyes4711-S73

LGTM

Alexgars73 · 2026-01-16T10:11:33Z

@lef-adhoc could you change the class text-right to text-end? text-right is obsolete and has no effect. Thanks!

alexey-pelykh

Migration Review

Good migration overall. The core discount logic, ORM patterns, view XML, and tests are solid. A few issues to address:

Blocking

Translation template mismatch -- The .pot file (and all .po files) reference %(dic_type)s but the Python source uses %(disc_type)s. These are different placeholder names. The .pot needs regeneration to match the actual source string. Translations referencing the wrong placeholder will produce a KeyError at runtime.
_compute_discounts returns True -- Odoo 19.0 compute methods should not return a value. Returning True is a legacy pattern. Remove the return True statement.

Non-blocking

CI is red -- All three test workflows are failing. The "Detect unreleased dependencies" failure is expected given the dependency on OCA/account-invoicing#2144. However, the actual test runs also fail, which should be investigated once the dependency PR is merged.
_additive_discount clamps negatives to 0 -- The additive method returns 0 for negative sums, but the multiplicative method allows negative results (surcharges). This behavioral inconsistency could confuse users if additive mode is ever fully enabled. Since additive is currently blocked via _discounting_type_additive_not_allowed, this is informational only.
create override fragility -- The logic in create that conditionally calls _compute_discounts based on comparing discount and discount1 values with vals is complex and could be fragile across Odoo upgrades. Consider adding a comment explaining the exact scenario this handles (e.g., when discount comes from a pricelist vs when it is manually set).

alexey-pelykh · 2026-03-01T16:50:10Z

+            raise ValidationError(
+                self.env._(
+                    "Sale order line %(name)s has unknown discounting type "
+                    "%(disc_type)s",


The .pot and .po files contain %(dic_type)s but this code passes disc_type= as the keyword argument. The translation template is out of sync with the source. Regenerate the .pot to fix; otherwise translated error messages will raise KeyError at runtime.

alexey-pelykh · 2026-03-01T16:50:10Z

+        # calling super ensures the cache is coherent before applying the inverse
+        super()._compute_discount()
+        self._inverse_discount()
+        return True


Compute methods in Odoo 19.0 should not return a value. Remove the return True.

lef-adhoc force-pushed the 19.0-mig-sale_triple_discount branch 5 times, most recently from af79003 to a3fe9ea Compare October 23, 2025 15:44

This was referenced Oct 23, 2025

[18.0][MIG] sale_triple_discount: Migration to version 18.0 #2093 #3889

Open

Migration to version 19.0 #3914

Open

ferran-S73 approved these changes Oct 24, 2025

View reviewed changes

tafaRU and others added 21 commits November 21, 2025 14:13

[ADD] sale_triple_discount

1b68516

[MIG] sale_triple_discount: Migration to 10.0

ae7afda

OCA Transbot updated translations from Transifex [UPD] Update sale_triple_discount.pot

[FIX] sale_triple_discount: Correctly compute taxes with round_global…

9a638fc

…ly configuration

sale_triple_discount: Fix tax total on report: include the discount2/…

fb42e3d

…3 in the computation

[IMP] 10.0 sale_triple_discount: rework discount computation

08dedac

Play onchange after invoice creation to ensure discounts are applied

6f67733

Fix groups on sale.order view

bb87130

[UPD] Update sale_triple_discount.pot

[IMP] sale_triple_discount: black, isort, prettier

47c07db

[MIG] sale_triple_discount: Migration to 13.0

9672b25

[IMP] sale_triple_discount: black, isort, prettier

9af379c

[14.0][MIG] sale_triple_discount: Migration to V14

b6c437d

[14.0][IMP] sale_triple_discount: add disc. fields in sale report templ.

91d980e

[14.0] sale_triple_discount: sale_order_line_discount_validation compat.

7a40e67

[UPD] Update sale_triple_discount.pot [UPD] README.rst

Translated using Weblate (French)

8309942

Currently translated at 0.0% (0 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_triple_discount/fr/

[IMP] sale_triple_discount: black, isort, prettier

16d1417

[MIG]sale_triple_discount: Migration to 15.0

0ea12b1

[UPD] Update sale_triple_discount.pot [UPD] README.rst

mymage and others added 17 commits November 21, 2025 14:13

Translated using Weblate (Italian)

ad983d0

Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/it/

[IMP] sale_triple_discount: improve module extensibility

5d9c1eb

Translated using Weblate (German)

494d485

Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/de/

[BOT] post-merge updates

e0c8a15

[FIX] sale_triple_discount: Remove call to deprecated

8ebacc6

Method 'invalidate_cache' is deprecated. To invalidate specific field's value into the cache for a recordset we must use the 'invalidate_recordset' method on the recordset itself.

[BOT] post-merge updates

26ad630

[BOT] post-merge updates

847f09c

[IMP] sale_triple_discount: pre-commit auto fixes

3a7c2bc

[MIG] sale_triple_discount: Migration to 17.0

4190e21

[MIG] sale_triple_discount: migration 18.0

5f47d18

[REF] sale_triple_discount: Consolidate discount in std field

362d5d4

inspired by OCA/account-invoicing#1638

[FIX] sale_triple_discount: hide discount_type and disable additive type

1b438ab

see OCA#3649

FIX sale_triple_discount: Calculate discounts when creating sales ord…

c366b73

…er lines

[IMP] sale_triple_discount: pre-commit execution

ccb73b7

lef-adhoc force-pushed the 19.0-mig-sale_triple_discount branch from a3fe9ea to 7db7948 Compare November 21, 2025 17:18

dreispt mentioned this pull request Jan 4, 2026

[19.0][MIG] sale_pricelist_triple_discount: Migration to 19.0 #4088

Open

1 task

OCA-git-bot added this to the 19.0 milestone Jan 4, 2026

Reyes4711-S73 approved these changes Jan 13, 2026

View reviewed changes

OCA-git-bot added the approved label Jan 13, 2026

WesleyOliveira98 approved these changes Jan 20, 2026

View reviewed changes

lef-adhoc added 2 commits January 21, 2026 16:57

[MIG] sale_triple_discount: Migration to 19.0

5520856

[DON'T MERGE] test-requirements.txt

cc16164

lef-adhoc force-pushed the 19.0-mig-sale_triple_discount branch from 7db7948 to cc16164 Compare January 21, 2026 19:57

pablo-cort-s73 mentioned this pull request Jan 30, 2026

[19.0][MIG] sale_order_general_discount_triple: Migration to 19.0 #4134

Open

1 task

alexey-pelykh reviewed Mar 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] sale_triple_discount: Migration to 19.0#3965

[19.0][MIG] sale_triple_discount: Migration to 19.0#3965
lef-adhoc wants to merge 51 commits intoOCA:19.0from
adhoc-dev:19.0-mig-sale_triple_discount

lef-adhoc commented Oct 23, 2025 •

edited by dreispt

Loading

Uh oh!

ferran-S73 left a comment

Uh oh!

lef-adhoc commented Oct 31, 2025

Uh oh!

dreispt commented Jan 4, 2026

Uh oh!

Reyes4711-S73 left a comment

Uh oh!

Alexgars73 commented Jan 16, 2026

Uh oh!

alexey-pelykh left a comment

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

lef-adhoc commented Oct 23, 2025 • edited by dreispt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ferran-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

lef-adhoc commented Oct 31, 2025

Uh oh!

dreispt commented Jan 4, 2026

Uh oh!

Reyes4711-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

Alexgars73 commented Jan 16, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Migration Review

Blocking

Non-blocking

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

lef-adhoc commented Oct 23, 2025 •

edited by dreispt

Loading