[19.0][MIG] sale_order_lot_selection: Migration to 19.0 by lef-adhoc · Pull Request #3985 · OCA/sale-workflow

lef-adhoc · 2025-11-03T20:51:27Z

Depends on:

[19.0][MIG] stock_restrict_lot: Migration to 19.0 stock-logistics-workflow#2151

[FIX] Fix product_id on test [FIX] Fix product on test

copy

of copy method

[FIX] Use product_14 instead of product_11 [FIX] Add test's flow step

[FIX] change data in quant search [FIX] Fixed tab [FIX] Add check on lots list FIX product_id_change_with_wh

Because quants_get_prefered_domain does not return quants with our lots, if other quants are available

…ot_id field

…roup_production_lot res.groups

Steps to reproduce: 1.- Create a new Sale Order with 2 or more lines of products 2.- Assign lot to every line (ensure lot has stock available) 3.- Confirm the Sale Order 4.- Go to the Delivery Order Result: Only the first line in the Delivery Order is in state "Available" and reserved, the rest of the lines are in state "Waiting Availability" and not reserved

…ects If we use the lot_id field to add it as a dependency of the _compute_price_unit method, we may encounter side effects, and indirectly we will need the field to be defined as precompute=True to avoid them.

…does not have tracking defined

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-18.0/sale-workflow-18.0-sale_order_lot_selection Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_order_lot_selection/

Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_order_lot_selection Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_order_lot_selection/it/

manuelcalerosolis

Functional review ok!

victoralmau · 2026-01-28T15:25:46Z

Please, cherry-pick #4011 to commit history before migration commit.

alexey-pelykh

Solid migration overall. The core lot selection logic, procurement integration, and view xpaths are correct for 19.0. A few observations:

Functional scope change -- The 16.0 version had allow_to_change_lot_on_confirmed_so (company setting + config view + write() override + lot_id_readonly computed field). All of this is dropped in the migration. If this is intentional simplification, it would be worth mentioning in the PR description or a migration note, since users upgrading from 16.0 will lose that capability.

Minor code observations:

_compute_product_tracking -- The fallback sol.product_id.tracking or sol.product_tracking works correctly for the visibility use-case but could be simplified to just sol.product_id.tracking since the compute fires on product_id change and the only consumer is the invisible expression. The or sol.product_tracking branch only preserves a stale value when product_id is cleared, which has no practical benefit since the field is hidden when not product_id anyway.
In the test test_02_sale_order_lot_selection, self.product_46.write({"tracking": "lot", "type": "consu"}) -- the "type": "consu" is a no-op in 19.0 since these products are already consu (created with is_storable=True). Not a bug, but dead code carried forward from older versions.
The product_tracking field is used in the view invisible expression but not declared in the view XML. Odoo 17+ auto-fetches fields in expressions, so this works, but adding <field name="product_tracking" column_invisible="True"/> would make the dependency explicit.

CI: "Detect unreleased dependencies" failure is expected due to the pending stock_restrict_lot migration (OCA/stock-logistics-workflow#2151).

Tests pass on both Odoo and OCB.

alexey-pelykh · 2026-03-01T16:46:33Z

+    @api.depends("product_id")
+    def _compute_product_tracking(self):
+        for sol in self:
+            sol.product_tracking = sol.product_id.tracking or sol.product_tracking


Nit: the or sol.product_tracking fallback is only reached when product_id is empty (since 'none' is truthy). In that case the view already hides the lot field via invisible="not product_id ...", so the preserved stale value has no visible effect. Could simplify to just:

sol.product_tracking = sol.product_id.tracking

Not blocking, just a readability point.

alexey-pelykh · 2026-03-01T16:46:33Z

+            if move.product_id == self.prd_cable:
+                lot10 = self.lot_model.create(
+                    {
+                        "name": "0000010",


Minor: "type": "consu" is redundant in 19.0 -- products created with is_storable=True already have type='consu'. This write effectively only sets tracking. Consider removing the type key to avoid confusion during future migrations.

alexey-pelykh · 2026-03-01T16:46:33Z

+                    context="{'default_product_id': product_id}"
+                    groups="stock.group_production_lot"
+                    optional="show"
+                />


Consider adding <field name="product_tracking" column_invisible="True"/> explicitly in the list view. While Odoo 17+ auto-fetches fields used in invisible expressions, declaring it makes the dependency clear and avoids surprises if that auto-fetch behavior ever changes.

odooNextev

tested locally, it works. lgtm

victoralmau

My comment #3985 (comment) is still pending.

…ock moves Example use case: - Product with Lot A and Lot B. - SO with Lot A linked. - The SO is confirmed and the OUT is generated with Lot A linked in the stock move - The SO is modified to define Lot B. - The OUT stock move is changed to Lot B. TT57112

lef-adhoc · 2026-03-11T14:42:18Z

@victoralmau Done!

BhaveshHeliconia

Functional review LGTM!

pedrobaeza · 2026-04-06T07:20:14Z

/ocabot migration sale_order_lot_selection

hurrinico and others added 30 commits November 3, 2025 17:38

[FIX] Add sale order dolder

102e1d7

[FIX] adds _run_move_create and some other fixes

c0c8b14

[FIX] add restriction on sale confirm changed icon and minor fix

f2bae28

[FIX] Fix product_id on test [FIX] Fix product on test

[FIX] Add check on sale order

63ea64b

[FIX] add _run override

31490e3

[FIX] adding feature and fix contributors

70a604d

Add transmition of lot_id from move to procurement and delete lot_id on

d0ffc46

copy

Extract move state check for easier inherit and add copy=False instead

be45fa5

of copy method

Fix pep8 and edit check move state

ee14a0e

Fix unused import

9948854

[IMP] better lot names in tests

50906b7

[FIX] Fixed Tests adding a stock_picking_in to create quants

c83a632

[FIX] Use product_14 instead of product_11 [FIX] Add test's flow step

[FIX] Add check on lot reservation in test

6cc1b84

[FIX] Add check on quants

165d8bf

[FIX] change data in quant search [FIX] Fixed tab [FIX] Add check on lots list FIX product_id_change_with_wh

Refactoring product_id_change_with_wh for domain generation.

c858c09

Because quants_get_prefered_domain does not return quants with our lots, if other quants are available

Refactoring tests, adding onchange tests

9a23606

Remove never used domain: on_change will set the correct domain for l…

3aea5d8

…ot_id field

IMP module version and fix comment

0935d13

the field lot_id should only be visible to the members of the stock.g…

2bdcb99

…roup_production_lot res.groups

REF some code and ADD lot11 has 1 availability and order4 has quantity 2

5b756ec

REF product_id_change_with_wh for compatibility with ohter override

0f96ff7

FIX default value in context

d8fa529

IMP README

6f081cd

FIX You cannot transfer a picking in state 'False'

8cfe7c0

[FIX] fix perf issue with sale_order_lot_selection

7956870

Migrate sale_order_lot_selection to v9

5daea09

[FIX] return super result after sale order confirm

af63995

[MIG] Make modules uninstallable

fa55c68

[MIG] Rename manifest files

e55102f

rousseldenis and others added 11 commits November 3, 2025 17:38

[FIX] sale_order_lot_selection: Don't use demo data for tests

3970ccc

[BOT] post-merge updates

79dff5e

[FIX] sale_order_lot_selection: Add precompute=True to avoid side eff…

7f30a64

…ects If we use the lot_id field to add it as a dependency of the _compute_price_unit method, we may encounter side effects, and indirectly we will need the field to be defined as precompute=True to avoid them.

[BOT] post-merge updates

78dc7bd

[IMP] sale_order_lot_selection: Hide the lot_id field if the product …

882ff50

…does not have tracking defined

[IMP] sale_order_lot_selection: Add optional=show to the lot_id field

8258d4e

[IMP] sale_order_lot_selection: Change TransactionCase to BaseCommon

ee0d3e5

[UPD] Update sale_order_lot_selection.pot

3faa1a7

[BOT] post-merge updates

18c0703

lef-adhoc mentioned this pull request Nov 3, 2025

Migration to version 19.0 #3914

Open

lef-adhoc force-pushed the 19.0-mig-sale_order_lot_selection branch from 2924a0a to 635139f Compare November 3, 2025 20:55

manuelcalerosolis reviewed Jan 23, 2026

View reviewed changes

alexey-pelykh reviewed Mar 1, 2026

View reviewed changes

odooNextev approved these changes Mar 10, 2026

View reviewed changes

victoralmau suggested changes Mar 11, 2026

View reviewed changes

victoralmau and others added 2 commits March 11, 2026 14:27

[MIG] sale_order_lot_selection: Migration to 19.0

c1db6d3

lef-adhoc force-pushed the 19.0-mig-sale_order_lot_selection branch 2 times, most recently from 9ea84b1 to f702c4a Compare March 11, 2026 14:33

[DON'T MERGE] test-requirements.txt

2bd743c

lef-adhoc force-pushed the 19.0-mig-sale_order_lot_selection branch from f702c4a to 2bd743c Compare March 11, 2026 14:38

victoralmau approved these changes Mar 16, 2026

View reviewed changes

OCA-git-bot added the approved label Mar 16, 2026

BhaveshHeliconia approved these changes Apr 6, 2026

View reviewed changes

OCA-git-bot added this to the 19.0 milestone Apr 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] sale_order_lot_selection: Migration to 19.0#3985

[19.0][MIG] sale_order_lot_selection: Migration to 19.0#3985
lef-adhoc wants to merge 88 commits intoOCA:19.0from
adhoc-dev:19.0-mig-sale_order_lot_selection

lef-adhoc commented Nov 3, 2025

Uh oh!

manuelcalerosolis left a comment

Uh oh!

victoralmau commented Jan 28, 2026

Uh oh!

alexey-pelykh left a comment

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

odooNextev left a comment

Uh oh!

victoralmau left a comment

Uh oh!

lef-adhoc commented Mar 11, 2026

Uh oh!

BhaveshHeliconia left a comment

Uh oh!

pedrobaeza commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

lef-adhoc commented Nov 3, 2025

Uh oh!

manuelcalerosolis left a comment

Choose a reason for hiding this comment

Uh oh!

victoralmau commented Jan 28, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

odooNextev left a comment

Choose a reason for hiding this comment

Uh oh!

victoralmau left a comment

Choose a reason for hiding this comment

Uh oh!

lef-adhoc commented Mar 11, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants