Skip to content

Conversation

@edescalona
Copy link
Contributor

@edescalona edescalona commented Nov 8, 2025

@BinhexTeam

A new field is added to the IDs so that more dynamic validations can be performed using a Python expression.

@edescalona edescalona force-pushed the 18.0-imp-sale_product_identification branch 2 times, most recently from 1a8510e to 870a9ba Compare November 8, 2025 04:18
@edescalona edescalona marked this pull request as ready for review November 8, 2025 04:28
@edescalona
Copy link
Contributor Author

Hello @arielbarreiros96 @epieters @rrebollo, if you could do a review of this PR, thank you.

Copy link

@epieters epieters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

LGTM!
However, I suggest adding some tests to assess the impact of the new feature on the existing flow.

@edescalona edescalona force-pushed the 18.0-imp-sale_product_identification branch from 63cdced to b38fc77 Compare November 10, 2025 22:56
@edescalona
Copy link
Contributor Author

Hi @rousseldenis can you review please?

@edescalona edescalona force-pushed the 18.0-imp-sale_product_identification branch from b38fc77 to 4f45d29 Compare December 3, 2025 17:20
@arielbarreiros96 arielbarreiros96 force-pushed the 18.0-imp-sale_product_identification branch from 4f45d29 to ddadbc8 Compare December 9, 2025 16:10
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants