-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[18.0][IMP] sale_product_identification #3998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0][IMP] sale_product_identification #3998
Conversation
1a8510e to
870a9ba
Compare
|
Hello @arielbarreiros96 @epieters @rrebollo, if you could do a review of this PR, thank you. |
epieters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
LGTM!
However, I suggest adding some tests to assess the impact of the new feature on the existing flow.
63cdced to
b38fc77
Compare
|
Hi @rousseldenis can you review please? |
sale_product_identification/models/product_template_id_category.py
Outdated
Show resolved
Hide resolved
b38fc77 to
4f45d29
Compare
…t identifications
4f45d29 to
ddadbc8
Compare
|
This PR has the |
@BinhexTeam
A new field is added to the IDs so that more dynamic validations can be performed using a Python expression.