[19.0][MIG] sale_fixed_discount: Migration to 19.0#4031
Closed
[19.0][MIG] sale_fixed_discount: Migration to 19.0#4031
Conversation
yankinmax
force-pushed
the
19.0-mig-sale_fixed_discount
branch
4 times, most recently
from
2089df0 to
4bdb8fb
Compare
jcoux
approved these changes
Nov 26, 2025
yankinmax
force-pushed
the
19.0-mig-sale_fixed_discount
branch
from
4bdb8fb to
abce36a
Compare
vvrossem
approved these changes
Nov 26, 2025
Contributor
ivantodorovich
approved these changes
Nov 26, 2025
instead of `sale.group_discount_per_so_line`
The sale order view in the portal was not displaying the fixed discount.
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_fixed_discount/es/
[17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [IMP]Improved for discount when discount_fixed being 0/false [17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [17.0][MIG]sale_fixed_discount: Migrated module to v17.0
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_fixed_discount/it/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_fixed_discount/es/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_fixed_discount/it/
Issue introduced in OCA#3150
yankinmax
force-pushed
the
19.0-mig-sale_fixed_discount
branch
from
abce36a to
6f5e95a
Compare
AndreuOForgeFlow
suggested changes
Jan 7, 2026
Contributor
AndreuOForgeFlow
left a comment
AndreuOForgeFlow
left a comment
There was a problem hiding this comment.
Small comment. The rest LGTM!
AndreuOForgeFlow
suggested changes
Jan 7, 2026
| expr="//field[@name='order_line']/form//label[@for='discount']" | ||
| position="before" | ||
| > | ||
| <field name="discount_fixed" groups="sale.group_discount_per_so_line" /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <field name="discount_fixed" groups="sale.group_discount_per_so_line" /> | |
| <field name="discount_fixed" optional="show" groups="sale.group_discount_per_so_line" /> |
It'd be nice if discount_fixed could be optionally hidden as a column in an SO
Contributor
|
/ocabot migration sale_fixed_discount |
rousseldenis
approved these changes
Jan 8, 2026
Contributor
|
@yankinmax could you remove the last commit so that @rousseldenis can merge this one? |
Contributor
|
@yankinmax could you also attend @AndreuOForgeFlow suggestion before this gets merged if possible? 🙏🏼 |
Contributor
|
Superseded here: |
Contributor
Author
|
hello guys, sorry was on a long vacation! Thanks for the follow-up @AndreuOForgeFlow |
Contributor
Hi @yankinmax, yes you can close this one. We'll continue here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.