[19.0][MIG] sale_invoice_policy: Migration to 19.0

[therbin200]

Dependency PR for module :
base_partition: #3465

[therbin200]

The precommit doesn't generat requirements.txt file. And if I try to make it manually, pre-commit automatically deletes it

[rousseldenis]

@therbin200 You should not do that.

To include open PR's dependencies, you should follow: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Thanks

[rousseldenis]

/ocabot migration sale_invoice_policy

[rousseldenis]

The precommit doesn't generat requirements.txt file. And if I try to make it manually, pre-commit automatically deletes it

That's normal. The dependent addon is not yet merged.

[therbin200]

The precommit doesn't generat requirements.txt file. And if I try to make it manually, pre-commit automatically deletes it

That's normal. The dependent addon is not yet merged.

So the pre-commit looks for the github repository dependencies, and not the local one on my computer ? How do I do in this case to pass the check on the PR ?

[therbin200]

Okay, everything must be okay now :)

[alexey-pelykh]

Thanks for the migration, @therbin200.

The code is a clean port from 18.0 -- models, views, hooks, and tests are all unchanged, which is exactly what you want for a straightforward migration. Tests pass on both Odoo and OCB, pre-commit is green, and the pyproject.toml issue @rousseldenis flagged has been addressed.

One thing to clean up:

• "base" was added to depends in __manifest__.py, but it's redundant since sale_stock already pulls it in transitively. The 18.0 manifest doesn't include it either. Removing it keeps the dependency tree accurate.

Minor observations (non-blocking):

• The .po translation files still carry references to the old invoice_policy_required / sale_invoice_policy_required fields that were removed in the 18.0 refactor. Not harmful (Odoo ignores orphaned translations), but they could be cleaned up with a fresh msgmerge against the updated .pot.
• The "Detect unreleased dependencies" CI failure is expected since base_partition (OCA/server-tools#3465) hasn't been merged yet. The test-requirements.txt workaround is set up correctly.

Overall this looks good -- just the "base" dependency to drop.

[alexey-pelykh]

"base" is redundant here -- sale_stock already depends on it transitively. The 18.0 version doesn't list it either. Suggest removing it to keep the dependency declaration accurate.

[alexey-pelykh]

Thanks for the work on this, @therbin200. As noted in my earlier comment, there's still one item to address before this can be approved:

The "base" dependency in __manifest__.py is redundant -- sale_stock already depends on it transitively, and the 18.0 manifest doesn't include it. Please remove it to keep the dependency tree clean.

Everything else looks solid: the models, views, hooks, and tests are a clean port from 18.0, tests pass on both Odoo and OCB, and pre-commit is green.