[19.0][MIG] product_customerinfo_sale

[JasminSForgeFlow]

Standard Migration

@ForgeFlow

Depends on:

• [19.0][MIG] product_customerinfo: Migration to 19.0 product-attribute#2167

[AaronHForgeFlow]

Functional test 👍

[rousseldenis]

/ocabot migration product_customerinfo_sale

[alexey-pelykh]

Thanks for the migration, looks solid overall -- tests are thorough and the code is clean.

One functional concern: _compute_product_customer_code depends only on product_id, but the computation uses order_partner_id. If the partner on the SO changes after a line already exists, the customer code won't recompute. Adding order_partner_id to the @api.depends would fix this.

Also a minor cleanup note: i18n/product_supplierinfo_for_customer_sale.pot is a leftover from the old module name and can be removed.

[alexey-pelykh]

This depends on product_id only, but the body calls _select_customerinfo(partner=line.order_partner_id). If the SO partner changes after lines exist, the customer code won't refresh. Consider:

@api.depends("product_id", "order_partner_id")

[alexey-pelykh]

Nit: the bare return at the end of the method is unnecessary (Python returns None implicitly). Feel free to drop it.

[JasminSForgeFlow]

This will cause missing-return warning in pre-commit

[alexey-pelykh]

This .pot file still references the old module name product_supplierinfo_for_customer_sale. Looks like a leftover from a previous version -- safe to remove.

[alexey-pelykh]

Thanks for migrating this to 19.0. The onchange rename (_onchange_product_id_warning -> _onchange_product_id) and the test adaptations (own product fixtures instead of demo data refs, group_ids rename) are the right changes for the new version.

One point that I flagged in my inline comments earlier and still stands: _compute_product_customer_code depends only on product_id, but the body reads order_partner_id to select the customerinfo. Since order_partner_id is a stored related field, adding it to @api.depends would make the code recompute correctly when the SO partner changes. This is technically a pre-existing issue from 18.0, but worth fixing while we're here.

The stale i18n/product_supplierinfo_for_customer_sale.pot is a leftover from the old module name and can be dropped.

Otherwise the manifest, security, views, and tests all look correct for 19.0.

[JasminSForgeFlow]

Thanks for migrating this to 19.0. The onchange rename (_onchange_product_id_warning -> _onchange_product_id) and the test adaptations (own product fixtures instead of demo data refs, group_ids rename) are the right changes for the new version.

One point that I flagged in my inline comments earlier and still stands: _compute_product_customer_code depends only on product_id, but the body reads order_partner_id to select the customerinfo. Since order_partner_id is a stored related field, adding it to @api.depends would make the code recompute correctly when the SO partner changes. This is technically a pre-existing issue from 18.0, but worth fixing while we're here.

The stale i18n/product_supplierinfo_for_customer_sale.pot is a leftover from the old module name and can be dropped.

Otherwise the manifest, security, views, and tests all look correct for 19.0.

Updated, Thanks

[BhaveshHeliconia]

LGTM!