[19.0][FIX] sale_advance_payment: Add check for paid orders in portal#4136
Open
ellbristow wants to merge 1 commit intoOCA:19.0from
Open
[19.0][FIX] sale_advance_payment: Add check for paid orders in portal#4136ellbristow wants to merge 1 commit intoOCA:19.0from
ellbristow wants to merge 1 commit intoOCA:19.0from
Conversation
alexey-pelykh
approved these changes
Feb 28, 2026
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for the fix! The _has_to_be_paid override is the right approach — checking amount_residual > 0 prevents the "Accept & Pay" button from appearing on already-paid orders. Clean and minimal.
LGTM.
Contributor
|
@ellbristow Could you squash your commits ? Thanks |
Prevent 'Accept & Pay' button for fully paid orders.
ellbristow
force-pushed
the
19-fix-sale_advance_payment
branch
from
c221be5 to
12bc592
Compare
Author
Sorry, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent 'Accept & Pay' button for fully paid orders.