Conversation
… and manual_force_sale_max_qty (imp user UI)
… other module & pep8
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/
Currently translated at 100.0% (51 of 51 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/it/
|
/ocabot migration sale_restricted_qty |
therbin200
force-pushed
the
19.0-mig-sale_restricted_qty
branch
from
c011775 to
3e917db
Compare
therbin200
force-pushed
the
19.0-mig-sale_restricted_qty
branch
from
3e917db to
7d5e345
Compare
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Clean 19.0 migration with proper migration scripts handling the column renames and flag conversions. LGTM
|
This PR has the |
|
@OCA/crm-sales-marketing-maintainers Please, can you review/merge this PR? |
|
You aggregated all the changed from 17.0 to 18.0 in the migration commit, right ? |
|
@mmequignon Fair points. The 18.0 PR (#3959) should indeed land first — it contains the baseline that 19.0 should be migrated from, and merging 19.0 before 18.0 would lose the intermediate history. @Reyes4711-S73 I would suggest waiting for #3959 to be merged, then rebasing this PR on top of it. That way the 19.0 migration commit only contains the actual 18.0→19.0 delta, preserving full git history. |
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for the migration work.
After looking at this more carefully alongside the 18.0 PR (#3959), I'm withdrawing my earlier approval. As @mmequignon noted, aggregating all the 17.0-to-18.0 changes into the migration commit loses the intermediate git history. The 18.0 PR is still open and has its own pending feedback (notably the float_is_zero remark on the modulo check in check_restricted_qty and _compute_restricted_qty_constraints -- raw qty % multiple_of_qty != 0 can misfire on float precision).
I'd recommend waiting for #3959 to land on 18.0 first, then rebasing this PR so the 19.0 migration commit only contains the actual 18.0-to-19.0 delta. That way:
- git history is preserved across versions,
- any fixes applied during 18.0 review (like
float_is_zero) carry forward automatically, and - the 19.0 migration path is cleaner.
The module structure, inheritance model, migration scripts, views, and tests all look solid otherwise -- no issues beyond the sequencing concern and the inherited float_is_zero gap.
16 participants
Migrated from v16, but taken v18 PR as a base (#3959) as it is ready to be merge and contains some minor improvements