[19.0][MIG] portal_sale_personal_data_only: Migration to version 19.0#4166
Open
cristina-hidalgo-tecnativa wants to merge 19 commits intoOCA:19.0from
Open
[19.0][MIG] portal_sale_personal_data_only: Migration to version 19.0#4166cristina-hidalgo-tecnativa wants to merge 19 commits intoOCA:19.0from
cristina-hidalgo-tecnativa wants to merge 19 commits intoOCA:19.0from
Conversation
[UPD] Update portal_sale_personal_data_only.pot
cristina-hidalgo-tecnativa
force-pushed
the
19.0-mig-portal_sale_personal_data_only
branch
from
3285818 to
836ecff
Compare
Member
|
/ocabot migration portal_sale_personal_data_only |
christian-ramos-tecnativa
suggested changes
Feb 23, 2026
cristina-hidalgo-tecnativa
force-pushed
the
19.0-mig-portal_sale_personal_data_only
branch
from
836ecff to
5d9807a
Compare
cristina-hidalgo-tecnativa
requested a review
from christian-ramos-tecnativa
christian-ramos-tecnativa
approved these changes
Feb 23, 2026
alexey-pelykh
approved these changes
Mar 1, 2026
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for the migration, @cristina-hidalgo-tecnativa!
Looks good. The 19.0 adaptations are clean and correct:
groups_id->group_idsrename: standard Odoo 19 change.sudo()onForm(self.env["sale.order"].sudo()): needed since portal users don't have sale order create rights- Explicit
message_subscribe(): properly handles the Odoo 19 change where partners are no longer auto-subscribed as followers on SO creation
Hooks, security rules, and manifest are all in order. Tests pass on both Odoo and OCB. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groups_id→group_idsin user creation (Odoo 19 standard field rename)message_subscribe()calls in tests.sudo()in sale order creation within tests cause portal users don't have create permissions for sale orders@Tecnativa TT58680
@christian-ramos-tecnativa @pedrobaeza