[19.0][MIG] sale_automatic_workflow_payment_mode: Migration to 19.0 by sergijPf · Pull Request #4198 · OCA/sale-workflow

sergijPf · 2026-03-09T14:40:46Z

as source 16.0 version module has been used for migration.

Few changes were done:

improved if-statement check - make sure invoice has payment_mode set inside _register_payment_invoice() method. Without it, 'sale_automatic_workflow' tests will fail;
remove 'picking_ids' in tests as functionality has been moved to different place;
added 'pre_compute=True' for sale_order's 'workflow_process_id' field.
'wokrflow_process_id' is set as computed field here and originally, it is added as dependency to '_compute_team_id()', which is pre-computed, as result it leads to issue that precomputed field cannot depend on non-precomputed, the relevant warning message is logged in console.

[ADD] sale_automatic_workflow_payment_mode

[MIG] Rename manifest files

[IMP] sale_automatic_workflow_payment_mode: Use related fields for payment_filter_domain & char_domain widget

Currently translated at 20.0% (2 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 30.0% (3 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 40.0% (4 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/zh_CN/

Currently translated at 90.0% (9 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/es/

Use Queue Jobs to process the Sales Automatic Workflow actions. The default behavior of the automatic workflow module is to use a scheduled action that searches all the record that need a workflow action and sequentially process all of them. It can hit some limits when the number of records is too high. This module keeps the scheduled action to search the records, but instead of directly executing the actions (confirm a sales order, create invoices for a sales order, validate invoices, ...), it creates one job per operation to do. It uses an identity key on the jobs so it will not create the same job for the same record and same operation twice. ~ I needed to extract methods in `sale_automatic_workflow` in order to be able to execute them as jobs. A new decorator "job_auto_delay" (to eventually move in queue_job) makes these methods automatically delayed when called.

Currently translated at 30.0% (3 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/sl/

… increase coverage

Parts of `sale_automatic_workflow_payment_mode` have been merged into `sale_automatic_workflow`. But these parts have been not removed from `sale_automatic_workflow_payment_mode`. This PR clean both modules after this merge. Originals PR of the merge: OCA#1789

…ng SO's workflow if payment.mode hasn't one set It seems this feature was added during the 14.0 migration PR, here: 111bb97 But it wasn't like this before, and IMO it was ok.

- Move register_payment option from sale_automatic_workflow_payment_mode to sale_automatic_workflow. - Add _register_payments function in sale_automatic_workflow. TT31208

...payment when no fixed journal and remove sale_workflow_process

* Fix tests errors

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow_payment_mode/es/

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow_payment_mode/pt_BR/

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow_payment_mode/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow_payment_mode/

Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow_payment_mode/it/

Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_automatic_workflow_payment_mode/hr/

rousseldenis · 2026-03-17T10:50:32Z

/ocabot migration sale_automatic_workflow_payment_mode

rousseldenis · 2026-03-17T10:52:17Z

@@ -1,2 +0,0 @@
-The migration of this module from 13.0 to 14.0 was financially supported


IMHO, this should not be removed (nothing to do with migration scripts)

revert it back now, no other changes

BhaveshHeliconia

LGTM!

OCA-git-bot · 2026-04-02T07:59:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Guewen Baconnier and others added 30 commits March 9, 2026 13:34

[WIP][9.0] Add sale_automatic_workflow_payment_mode (OCA#297)

c875b45

[ADD] sale_automatic_workflow_payment_mode

[MIG] Make modules uninstallable

57c8594

[MIG] Rename manifest files

[MIG] sale_automatic_workflow_payment_mode: Upgrade to v10

6307354

[IMP] sale_automatic_workflow_payment_mode: improve test coverage

7394813

[IMP] sale_automatic_workflow_payment_mode: OCA conventions

8b59172

[IMP] sale_automatic_workflow_payment_mode: Use related fields for payment_filter_domain & char_domain widget

[MIG] sale_automatic_workflow_payment_mode to V11

800f6fa

[11.0] [MIG]sale_procurement_group_by_line: Migration to 11.0.

e99b770

Migration to version 12.0

dfa1348

[IMP] sale_automatic_workflow_payment_mode cosmetics

9241306

[FIX] pep8 and pylint

e110b4e

[MIG] sale_automatic_workflow_payment_mode from 12.0 to 13.0

745023b

[MIG] sale_automatic_workflow_payment_mode: run pre-commit

69c8bb4

[IMP] sale_automatic_workflow_payment_mode: black, isort, prettier

5b8c545

[MIG] sale_automatic_workflow_payment_mode: Migration to 14.0

cdef896

[IMP] sale_automatic_workflow_payment_mode: sync SO workflow process,…

b9e51b9

… increase coverage

[FIX] sale_automatic_workflow_payment_mode: avoid overwritting/removi…

fc5c09d

…ng SO's workflow if payment.mode hasn't one set It seems this feature was added during the 14.0 migration PR, here: 111bb97 But it wasn't like this before, and IMO it was ok.

sale_automatic_workflow_payment_mode 14.0.1.0.1

4e3c496

[IMP] sale_automatic_workflow:

8ed66c2

- Move register_payment option from sale_automatic_workflow_payment_mode to sale_automatic_workflow. - Add _register_payments function in sale_automatic_workflow. TT31208

[FIX] sale_automatic_workflow_mode: missing super()

7f0b362

[FIX] sale_automatic_workflow_payment_mode: not register...

3348e00

...payment when no fixed journal and remove sale_workflow_process

[MIG] sale_automatic_workflow_payment_mode 15.0 &

80976e8

* Fix tests errors

[16.0][MIG] Migrate sale_automatic_workflow_payment_mode to v16

1c2efaa

oca-ci and others added 13 commits March 9, 2026 13:34

[UPD] Update sale_automatic_workflow_payment_mode.pot

0b2f0bb

[UPD] README.rst

3c01389

[UPD] README.rst

fb77f83

[IMP] sale_automatic_workflow_payment_mode: pre-commit auto fixes

81ecac8

sergijPf force-pushed the 19.0-mig-sale_automatic_workflow_payment_mode branch from fbd61b0 to 7f86134 Compare March 9, 2026 16:56

rousseldenis added needs review migration labels Mar 17, 2026

OCA-git-bot added this to the 19.0 milestone Mar 17, 2026

OCA-git-bot mentioned this pull request Mar 17, 2026

Migration to version 19.0 #3914

Open

rousseldenis reviewed Mar 17, 2026

View reviewed changes

sergijPf force-pushed the 19.0-mig-sale_automatic_workflow_payment_mode branch from 7f86134 to 7de5e43 Compare March 17, 2026 12:47

[MIG] sale_automatic_workflow_payment_mode: Migration to 19.0

31edd7b

sergijPf force-pushed the 19.0-mig-sale_automatic_workflow_payment_mode branch from 7de5e43 to 31edd7b Compare March 17, 2026 12:49

rousseldenis approved these changes Mar 25, 2026

View reviewed changes

BhaveshHeliconia approved these changes Apr 2, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] sale_automatic_workflow_payment_mode: Migration to 19.0#4198

[19.0][MIG] sale_automatic_workflow_payment_mode: Migration to 19.0#4198
sergijPf wants to merge 44 commits intoOCA:19.0from
DeineTuer-GmbH:19.0-mig-sale_automatic_workflow_payment_mode

sergijPf commented Mar 9, 2026 •

edited

Loading

Uh oh!

rousseldenis commented Mar 17, 2026

Uh oh!

rousseldenis Mar 17, 2026

Uh oh!

sergijPf Mar 17, 2026

Uh oh!

BhaveshHeliconia left a comment

Uh oh!

OCA-git-bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		@@ -1,2 +0,0 @@
		The migration of this module from 13.0 to 14.0 was financially supported

Uh oh!

Conversation

sergijPf commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rousseldenis commented Mar 17, 2026

Uh oh!

rousseldenis Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

sergijPf Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

sergijPf commented Mar 9, 2026 •

edited

Loading