Open
Conversation
luisDIXMIT
reviewed
Mar 31, 2026
Contributor
luisDIXMIT
left a comment
There was a problem hiding this comment.
When a sale is marked as finished,
Grabacion.de.pantalla.desde.2026-03-31.08-47-53.mp4
it is not searchable on timesheets but by default is setted. I show you in a video.
Member
Author
|
@luisDIXMIT I see the problem, however, that might happen also without this module if we cancel a Sale Order. it will still be used 🤔 If we want to fix this, we probably need to change Odoo core to fix it 🤔 |
luisDIXMIT
approved these changes
Apr 7, 2026
Contributor
luisDIXMIT
left a comment
There was a problem hiding this comment.
Since my comments are not related to the module, I tested it on Runboat and the behavior is correct. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odoo way of handling sale orders has only 4 states (draft, sent, sale,
cancel).
Also, on all services sale orders (linked to timesheets), it only checks
if the sale order is in state sale. In projects, it works fine, but it
can lead to errors on users, because they are not allowed to "close" an
existing sale order.
The concept of this module is to add a new flag that will detected
"finished sale orders" and will not allow to select them anymore.
Usage
Access a sale order. When it is in state sale order, a Finish/Unfinish
button will appear in top.