Skip to content

[18.0][ADD] sale_order_finish_service#4239

Open
etobella wants to merge 1 commit intoOCA:18.0from
dixmit:18.0
Open

[18.0][ADD] sale_order_finish_service#4239
etobella wants to merge 1 commit intoOCA:18.0from
dixmit:18.0

Conversation

@etobella
Copy link
Copy Markdown
Member

Odoo way of handling sale orders has only 4 states (draft, sent, sale,
cancel).

Also, on all services sale orders (linked to timesheets), it only checks
if the sale order is in state sale. In projects, it works fine, but it
can lead to errors on users, because they are not allowed to "close" an
existing sale order.

The concept of this module is to add a new flag that will detected
"finished sale orders" and will not allow to select them anymore.

Usage

Access a sale order. When it is in state sale order, a Finish/Unfinish
button will appear in top.

@etobella etobella changed the title [ADD] sale_order_finish_service [18.0][ADD] sale_order_finish_service Mar 31, 2026
Copy link
Copy Markdown
Contributor

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a sale is marked as finished,

Grabacion.de.pantalla.desde.2026-03-31.08-47-53.mp4

it is not searchable on timesheets but by default is setted. I show you in a video.

@rousseldenis rousseldenis added this to the 18.0 milestone Mar 31, 2026
@etobella
Copy link
Copy Markdown
Member Author

etobella commented Apr 7, 2026

@luisDIXMIT I see the problem, however, that might happen also without this module if we cancel a Sale Order. it will still be used 🤔

If we want to fix this, we probably need to change Odoo core to fix it 🤔

Copy link
Copy Markdown
Contributor

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since my comments are not related to the module, I tested it on Runboat and the behavior is correct. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants