[19.0][FIX] sale_global_discount: discount amounts on orders without …#4241
Merged
OCA-git-bot merged 1 commit intoOCA:19.0from Apr 9, 2026
Merged
[19.0][FIX] sale_global_discount: discount amounts on orders without …#4241OCA-git-bot merged 1 commit intoOCA:19.0from
OCA-git-bot merged 1 commit intoOCA:19.0from
Conversation
Contributor
|
This PR has the |
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 7aa1d65. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When modifying quantities on a confirmed order that has no global discounts, the fields amount_untaxed_before_global_discounts and amount_total_before_global_discounts were not being updated.
The _compute_amounts method used an early continue when global_discount_ids was empty, leaving those compute fields unassigned and retaining stale data in the cache/database.
Explicitly assign the standard untaxed and total amounts to the "before discount" fields, and set the global discount amount to 0.0 before continuing the loop.