[18.0][MIG] sale_start_end_dates: Migration to 18.0 by IJOL · Pull Request #4248 · OCA/sale-workflow

IJOL · 2026-04-01T15:41:29Z

Summary

Port sale_start_end_dates from 16.0 to 18.0
Replace states= field attribute with readonly=False (computed stored fields)
Replace attrs= with direct invisible=/required= expressions
Replace tree with list in XML views
Replace invisible=1 with column_invisible=True for hidden fields
Remove pricelist_id from test (product.list0 xmlid removed in v18)
Version bump to 18.0.1.0.0
Pre-commit auto fixes applied

Tests

6 tests pass locally (0 failures, 0 errors)

Replace openerp by odoo in import declarations

Currently translated at 100,0% (16 of 16 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_start_end_dates/nl_NL/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Convert readme to new subdir format

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/

Currently translated at 26.7% (4 of 15 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/pt/

Improve and update some strings Update FR translation

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/es/

Currently translated at 71.4% (10 of 14 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/

Currently translated at 53.3% (8 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/es/

Currently translated at 66.6% (10 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/pt_BR/

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

rousseldenis · 2026-04-09T06:43:59Z

/ocabot migration sale_start_end_dates

OCA-git-bot · 2026-04-09T06:44:17Z

The migration issue (#3344) has not been updated to reference the current pull request because a previous pull request (#3505) is not closed.
Perhaps you should check that there is no duplicate work.
CC @alexis-via

rousseldenis · 2026-04-09T06:44:57Z

+                        "or be the same as Default End Date (%(end_date)s) "
+                        "for sale order '%(name)s'."
                    )
                    % {


You should use translation function arguments instead.

rousseldenis · 2026-04-09T06:45:12Z

+                            "for sale order line "
                            "with Product '%(product_name)s'."
                        )
                        % {


Same as above

IJOL · 2026-04-09T07:13:47Z

Closing in favor of #3505 by @alexis-via (original author), which is more complete and includes sale.report improvements.

Alexis de Lattre and others added 30 commits April 1, 2026 18:48

Initial check-in of the rental project.

2d1e5e0

Port to v8 and new API with several enhancements

1836de7

Slovene translations added

8916508

OCA Transbot updated translations from Transifex

db0f9e0

Port sale_start_end_dates and sale_rental (OCA#353)

c439817

sale_start_end_dates and sale_rental

bb035b2

Product qty on rental pickings

f1016d5

Replace openerp by odoo in import declarations

Update sale_start_end_dates.pot

780348c

sale_start_end_dates: Migration to 11.0.

3060ea2

Update sale_start_end_dates.pot

65a7b44

Update translation files

aacc310

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] sale_start_end_dates and sale_rental to v12

e6ad719

Convert readme to new subdir format

[FIX] sale_start_end_dates: bad code in compute method

b0a4274

[UPD] Update sale_start_end_dates.pot

c8c8f81

[UPD] README.rst

202ebbd

Translated using Weblate (Portuguese)

cf91677

Currently translated at 26.7% (4 of 15 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/pt/

[MIG] sale_start_end_dates to v13

f8bfd49

Black/flake8 fight

fe51ee2

Add maintainers key in manifest

ac818b6

[MIG] sale_start_end_dates to v14

9b9be8b

[UPD] Update sale_start_end_dates.pot

ac2f5e8

[UPD] README.rst

3ab5964

[MIG] sale_start_end_dates to v15

027bb19

[UPD] Update sale_start_end_dates.pot

7abab7f

[UPD] README.rst

344795a

sale_start_end_dates 15.0.1.0.1

5bf7804

[UPD] README.rst

9749696

[UPD] README.rst

4bb2641

vancouver29 and others added 17 commits April 1, 2026 18:48

[MIG] sale_start_end_dates: Migration to 16.0

e361a65

sale_start_end_dates: onchange -> compute methods

fcb14f7

Improve and update some strings Update FR translation

Fix Singleton Exception (OCA#29)

44a5504

[UPD] Update sale_start_end_dates.pot

303e4c5

[UPD] README.rst

1c00ea4

sale_start_end_dates 16.0.1.0.1

6d13a23

Translated using Weblate (Spanish)

4b0f72b

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/es/

[UPD] README.rst

b3342f7

Translated using Weblate (Italian)

19f8cb7

Currently translated at 71.4% (10 of 14 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Translated using Weblate (Italian)

4583ab2

Currently translated at 53.3% (8 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Translated using Weblate (Spanish)

b14e55d

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/es/

Translated using Weblate (Italian)

3e92798

Currently translated at 66.6% (10 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Translated using Weblate (Italian)

10d60d1

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Translated using Weblate (Italian)

e9cb96d

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

Translated using Weblate (Italian)

7aa2909

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/

IJOL force-pushed the 18.0-mig-sale_start_end_dates branch from d88f55a to 9c7e542 Compare April 1, 2026 16:50

[MIG] sale_start_end_dates: Migration to 18.0

56913e6

IJOL force-pushed the 18.0-mig-sale_start_end_dates branch from 9c7e542 to 56913e6 Compare April 1, 2026 19:28

rousseldenis added needs review migration labels Apr 9, 2026

OCA-git-bot added this to the 18.0 milestone Apr 9, 2026

rousseldenis reviewed Apr 9, 2026

View reviewed changes

IJOL closed this Apr 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0][MIG] sale_start_end_dates: Migration to 18.0#4248

[18.0][MIG] sale_start_end_dates: Migration to 18.0#4248
IJOL wants to merge 48 commits intoOCA:18.0from
BITVAX:18.0-mig-sale_start_end_dates

IJOL commented Apr 1, 2026

Uh oh!

rousseldenis commented Apr 9, 2026

Uh oh!

OCA-git-bot commented Apr 9, 2026

Uh oh!

rousseldenis Apr 9, 2026

Uh oh!

rousseldenis Apr 9, 2026

Uh oh!

IJOL commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

IJOL commented Apr 1, 2026

Summary

Tests

Uh oh!

rousseldenis commented Apr 9, 2026

Uh oh!

OCA-git-bot commented Apr 9, 2026

Uh oh!

rousseldenis Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

rousseldenis Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

IJOL commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants