Repository navigation
[19.0][FIX] password_security: keep password_write_date when the new password is rejected - #1072
Open
alvaro-domatix wants to merge 1 commit into
Conversation
…password is rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user with an expired password is sent to the reset page and types one of their previous passwords, the history check rejects it, but
password_write_datehas already been set in the samewrite()call.web_auth_reset_password(and the portal security page) catch theUserErrorand the request is committed, so the expiration date is refreshed although the password did not change. On the next login the old password is accepted again for another full period.Steps to reproduce:
/web/reset_password.password_write_dateis now today.This change writes
password_write_dateonly oncesuper().write()has succeeded. The new test fails without the change, and the wholepassword_securitysuite passes with it.As far as we can tell the same happens in 17.0 and 18.0, and we can open the backports if this approach looks right to you. We may be missing a reason to write the date in the same call, so please let us know if there is a preferred way.