Skip to content

[16.0] [ADD] cross_connect_server#734

Merged
OCA-git-bot merged 3 commits intoOCA:16.0from
akretion:16.0-add-cross_connect_server
Apr 3, 2025
Merged

[16.0] [ADD] cross_connect_server#734
OCA-git-bot merged 3 commits intoOCA:16.0from
akretion:16.0-add-cross_connect_server

Conversation

@paradoxxxzero
Copy link
Copy Markdown
Contributor

@paradoxxxzero paradoxxxzero commented Dec 12, 2024

This module allows other odoo instances, where the cross_connect_client (#735) module is
installed and configured, users to connect directly on this odoo instance.

(Needed to bump precommit flake8 version for annotation support)

@paradoxxxzero paradoxxxzero force-pushed the 16.0-add-cross_connect_server branch 3 times, most recently from 7c9a99d to 18f12ee Compare December 12, 2024 17:15
@paradoxxxzero paradoxxxzero marked this pull request as ready for review December 13, 2024 15:31
@legalsylvain
Copy link
Copy Markdown
Contributor

legalsylvain commented Mar 11, 2025

hi @paradoxxxzero
could you rebase ? there is a trivial conflict in pre-commit file.

thanks !

@paradoxxxzero paradoxxxzero force-pushed the 16.0-add-cross_connect_server branch from 18f12ee to 38473f4 Compare March 13, 2025 15:11
@paradoxxxzero
Copy link
Copy Markdown
Contributor Author

hi @paradoxxxzero could you rebase ? there is a trivial conflict in pre-commit file.

thanks !

Done!

@paradoxxxzero paradoxxxzero force-pushed the 16.0-add-cross_connect_server branch from 38473f4 to e2ff3f5 Compare March 31, 2025 16:00
Copy link
Copy Markdown
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review + tests

Comment thread cross_connect_server/models/cross_connect_client.py Outdated
Copy link
Copy Markdown
Member

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review), minor change on login value

Copy link
Copy Markdown
Member

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review) and test

@sebastienbeau
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-734-by-sebastienbeau-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 3, 2025
Signed-off-by sebastienbeau
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-734-by-sebastienbeau-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rvalyi
Copy link
Copy Markdown
Member

rvalyi commented Apr 3, 2025

/ocabot merge patch

@sebastienbeau I stopped the merge because it should be nobump for module addition....

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-734-by-rvalyi-bump-nobump, awaiting test results.

@sebastienbeau
Copy link
Copy Markdown
Member

@rvalyi thanks

@OCA-git-bot OCA-git-bot merged commit 647d253 into OCA:16.0 Apr 3, 2025
9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a8ee65e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants