[18.0][MIG] cross_connect_client : Migration to 18.0#782
[18.0][MIG] cross_connect_client : Migration to 18.0#782OCA-git-bot merged 11 commits intoOCA:18.0from
Conversation
TB-Ph35
force-pushed
the
18.0-mig-cross_connect_client
branch
2 times, most recently
from
271717c to
a034a09
Compare
We want to avoid deletion of the group because we would then loose all users configured on it. So we prefer to remove the link between the cross connect server and the group instead
TB-Ph35
force-pushed
the
18.0-mig-cross_connect_client
branch
from
d122445 to
4328e2d
Compare
florian-dacosta
left a comment
florian-dacosta
left a comment
There was a problem hiding this comment.
LGTM (code review)
| self.ensure_one() | ||
| groups = self.env.user.groups_id & self.group_ids | ||
| if not groups: | ||
| raise UserError(_("You are not allowed to access this server")) |
There was a problem hiding this comment.
OCA 18.0 guideline: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
please use self.env._() instead of _() for translations.
| raise UserError(_("You are not allowed to access this server")) | ||
|
|
||
| if not self.env.user.email: | ||
| raise UserError(_("User email is required")) |
There was a problem hiding this comment.
OCA 18.0 guideline: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
please use self.env._() instead of _() for translations.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
florian-dacosta
force-pushed
the
18.0-mig-cross_connect_client
branch
from
4328e2d to
dcada6f
Compare
|
@sebastienbeau @paradoxxxzero A review please ? |
github-actions
Bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
…-param [IMP] cross_connect_client: Work with params and not server redirect_url
|
This PR has the |
|
@bguillot Can you merge this one please ? |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 81002e1. Thanks a lot for contributing to OCA. ❤️ |
7 participants
No description provided.