Skip to content

17.0 [IMP] auditlog: Modernize http_session display_name computation#3437

Closed
drkpkg wants to merge 0 commit into
OCA:17.0from
drkpkg:17.0
Closed

17.0 [IMP] auditlog: Modernize http_session display_name computation#3437
drkpkg wants to merge 0 commit into
OCA:17.0from
drkpkg:17.0

Conversation

@drkpkg

@drkpkg drkpkg commented Nov 5, 2025

Copy link
Copy Markdown
  • Replace and/or pattern with ternary operator (PEP 308)
  • Replace .format() with f-strings (PEP 498)
  • Add explicit create_date None check for edge cases
  • Remove deprecated fields.Datetime.from_string() call
  • Add bulk server actions for subscribe and unsubscribe
  • Add base pot file for new translations

The old and/or pattern can fail with falsy but valid values. The ternary operator is safer and more readable.

@drkpkg drkpkg changed the title [IMP] auditlog: Modernize http_session display_name computation 17.0 [IMP] auditlog: Modernize http_session display_name computation Nov 5, 2025

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Http session create_date edge case is already handled in #3432. Can you review it? If we can get it merged quickly, you can rebase your PR with the leftovers.

@drkpkg

drkpkg commented Nov 7, 2025

Copy link
Copy Markdown
Author

Http session create_date edge case is already handled in #3432. Can you review it? If we can get it merged quickly, you can rebase your PR with the leftovers.

Thanks for the heads-up! I’ve reviewed #3432 and it looks good to me—please go ahead and merge when you’re ready. I’ll rebase my branch afterwards and handle any remaining bits.

@StefanRijnhart

Copy link
Copy Markdown
Member

Thanks but I actually need you to go through the motions 😄

image

@drkpkg

drkpkg commented Nov 7, 2025

Copy link
Copy Markdown
Author

Thanks but I actually need you to go through the motions 😄

image

Oh snap. Give me a second.

@drkpkg

drkpkg commented Nov 7, 2025

Copy link
Copy Markdown
Author

Done.

@StefanRijnhart

Copy link
Copy Markdown
Member

Thanks, merging that one. If you rebase your changes, please note that the pot file will automatically be updated by the OCA github bot. Please leave it out to prevent conflicts with concurrent changes to the same module that also lead to changes to translation terms.

@drkpkg

drkpkg commented Nov 7, 2025

Copy link
Copy Markdown
Author

Sure, I'll do the corrections once I rebase the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants