[18.0][IMP] shopfloor_base: Allow changing the way locks are acquired#24
Open
grindtildeath wants to merge 2 commits intoOCA:18.0from
Open
[18.0][IMP] shopfloor_base: Allow changing the way locks are acquired#24grindtildeath wants to merge 2 commits intoOCA:18.0from
grindtildeath wants to merge 2 commits intoOCA:18.0from
Conversation
Contributor
f862414 to
3753515
Compare
Contributor
Author
|
Logging testing on odoo shell: |
153a6dd to
8f360c1
Compare
gurneyalex
approved these changes
Feb 16, 2026
Member
gurneyalex
left a comment
There was a problem hiding this comment.
pre-commit is complaining. But LGTM otherwise
henrybackman
approved these changes
Feb 17, 2026
TDu
approved these changes
Feb 24, 2026
This commit adds two new system parameters: * shopfloor.lock.for_update.no_key: Can be defined with a True-ish value to use FOR NO KEY UPDATE in the select to acquire a lock on selected rows * shopfloor.lock.for_update.no_wait: Can be defined with a True-ish value to use NOWAIT and raise an error instead of waiting for the lock to be acquired. Note that NOWAIT keyword cannot be use in conjunction with SKIP LOCKED, hence, if skip_locked arg is used, the value of no_wait parameter will be ignored.
8f360c1 to
d8c8c20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds two new system parameters:
shopfloor.lock.for_update.no_key: Can be defined with a True-ish value to use FOR NO KEY UPDATE in the select to acquire a lock on selected rows
shopfloor.lock.for_update.no_wait: Can be defined with a True-ish value to use NOWAIT and raise an error instead of waiting for the lock to be acquired.
Note that NOWAIT keyword cannot be use in conjunction with SKIP LOCKED, hence, if skip_locked arg is used, the value of no_wait parameter will be ignored.