[16.0][IMP] stock_location_orderpoint: returns the ongoing replenishment moves. #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mt-software-de, |
nicolas-delbovier-acsone
force-pushed
the
stock-location-orderpoint-return-assigned-replenishment-moves
branch
from
6b0193b to
5244aff
Compare
nicolas-delbovier-acsone
changed the title
nicolas-delbovier-acsone
force-pushed
the
stock-location-orderpoint-return-assigned-replenishment-moves
branch
2 times, most recently
from
b6af5b1 to
6328ebb
Compare
nicolas-delbovier-acsone
changed the title
Some test was failing because the code saying "day +1" fails if we are the last day of a month.
…replenishment moves
nicolas-delbovier-acsone
force-pushed
the
stock-location-orderpoint-return-assigned-replenishment-moves
branch
from
6328ebb to
f712e4b
Compare
|
I forced push to rebase to #54 |
nicolas-delbovier-acsone
changed the title
nicolas-delbovier-acsone
changed the title
mt-software-de
suggested changes
Jul 31, 2025
| self.env["procurement.group"].with_context(from_orderpoint=True).run( | ||
| procurements, raise_user_error=False | ||
| ) | ||
| return self._after_replenishment() |
There was a problem hiding this comment.
I would rather move the logic for getting the current replenishment moves into here and then passing them on downwards, instead of getting them from the result of _after_replenishment.
Suggested change
| return self._after_replenishment() | |
| replenishment_moves = self._get_current_replenishment_moves() | |
| self._after_replenishment(replenishment_moves) | |
| return replenishment_moves |
There was a problem hiding this comment.
You are right, this is probably better to put this logic there, I'll make a commit
…ng logic to main replenishment method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the replenishment method always returns its ongoing replenishment moves.
This is useful in case we want to add custom logic to the generated/updated replenishment moves. If the moves get returned, we do not need to make a second query to gather them afterwards.
This PR is based on #54