Skip to content

Conversation

@trisdoan
Copy link

Note

This changes

This PR includes:

  • [IMP] shipment_advice: Add action on shipment advice to print delivery slip
  • [ADD] shipment_advice_cash_on_delivery: Add action on shipment advice to print cash on delivery invoices
  • [REF] shipment_advice_cash_on_delivery: Extract cash on delivery to separate module

@trisdoan trisdoan marked this pull request as draft June 27, 2024 16:49
@trisdoan
Copy link
Author

DRAFT: working on failed test

Comment on lines +9 to +15


class TestShipmentAdviceCashOnDelivery(Common):
@classmethod
def setUpClass(cls):
super().setUpClass()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class TestShipmentAdviceCashOnDelivery(Common):
@classmethod
def setUpClass(cls):
super().setUpClass()
from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
class TestShipmentAdviceCashOnDelivery(Common):
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.env = cls.env["base"].with_context(**DISABLED_MAIL_CONTEXT).env

Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approval after fixing test

@rrebollo
Copy link

@trisdoan would you be so kind to rebase?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@trisdoan trisdoan force-pushed the 16.0-imp-shipment_advice branch from c7499c6 to e384cdd Compare October 20, 2025 02:21
@trisdoan trisdoan marked this pull request as draft October 20, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved no stale Use this label to prevent the automated stale action from closing this PR/Issue. ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants