Skip to content

[16.0][FW] [14.0] shipment_advice: load a transfer in multiple shipments + list goods that could be loaded (new smart button) #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
giarve wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][FW] [14.0] shipment_advice: load a transfer in multiple shipments + list goods that could be loaded (new smart button) #156

giarve wants to merge 2 commits into from

Conversation

@giarve
Copy link
Contributor

@giarve giarve commented Nov 17, 2024

Port of #96 from 14.0 to 16.0.

I realised these commits were missing. In 16.0 the leave_open is handled by leaving an error on SA when confirming the Shipment Advice. In 14.0 it was just validated. That's why you will see I changed some tests and added flags to handle that with a leave_open policy it should not error. This can be discussed.

Porting the second commit will unlock:
OCA/wms#944

lmignon
lmignon approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the forward port. LGTM (no tests)

@github-actions
Copy link

github-actions bot commented Mar 23, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 23, 2025
bosd
bosd approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review, LGTM 👍

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 30, 2025
@github-actions
Copy link

github-actions bot commented Aug 3, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 3, 2025
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 7, 2025
@sebalix @giarve
shipment_advice: load a transfer in multiple shipments
04669f3 
Two use cases here:

1) Load all the transfer lines in two shipments:
    => Validate the first shipment: the transfer is not validated
    => Validate the second shipment: the transfer is then validated

2) No backorder policy, load partially a transfer, validate the shipment,
load the remaining goods in a second shipment and validate it:
    => the transfer is not validated during the validation of the first
    shipment (left open thanks to the BO policy)
    => the transfer is then validated during the validation of the
    second shipment.
@sebalix @giarve
shipment_advice: list goods to load (new smart button)
861bc6f
@giarve giarve force-pushed the oca-port-shipment_advice-14.0-to-16.0-22f8f1 branch from 03424e2 to 861bc6f Compare September 11, 2025 18:15
@rrebollo
Copy link

rrebollo commented Oct 17, 2025

Hi folks, is there any way we can get this finally merged?

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 17, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lmignon lmignon lmignon approved these changes

@bosd bosd bosd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@giarve @rrebollo @OCA-git-bot @lmignon @bosd @sebalix