Skip to content

Conversation

@giarve
Copy link
Contributor

@giarve giarve commented Jan 13, 2025

Moving from here due to a branch change

#155

Should I add the stock quant package dimension module as dependency or
create another extension module as shipment_advice_volume?

I think that most of the times the package volume module will be installed
but we can decide.

@bosd
Copy link
Contributor

bosd commented Mar 27, 2025

@giarve Thanks for this contribution. Can you please rebase to trigger runboat creation?

@giarve
Copy link
Contributor Author

giarve commented Mar 29, 2025

@giarve Thanks for this contribution. Can you please rebase to trigger runboat creation?

Done!

Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@github-actions
Copy link

github-actions bot commented Aug 3, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 3, 2025
@bosd
Copy link
Contributor

bosd commented Aug 3, 2025

Can you please rebate?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 10, 2025
@jbaudoux jbaudoux added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Aug 13, 2025
@rrebollo
Copy link

Hi folks, is there any way we can get this finally merged?

@giarve giarve force-pushed the 16.0-volume branch 3 times, most recently from 9f4d4e3 to d31bb78 Compare October 20, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants