[Fix] shipment_advice : release the lock_records on picking if excepion raise #197
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemannd
approved these changes
Nov 4, 2025
Contributor
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that if a cron job executed this validate_picking method on a task and it failed for some reason, when the action was restarted, the lock was not released because the code attempted to perform an operation after locking (meaning that the lock would be released by the ~20m timeout defined in the database).
case of error or rollback, the data will return on the self.env.cr.savepoint() that mean the lock will rest as it is because the update was not made and the retry of the job will retry to do all the method.
performance issue.