Skip to content

Conversation

@bartacruz
Copy link

In the module tms_expense (v17.0), when trying to import drivers, the system tries to create an employee even when the driver is marked as "external".

Ref: #198

@OCA-git-bot
Copy link
Contributor

Hi @EdgarRetes, @max3903, @santiagordz,
some modules you are maintaining are being modified, check this out!

@rrebollo
Copy link

Please rename to "[17.0] [FIX] tms_expense: ..."

Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for your contribution. Please re-write commit message to something along "[FIX] tms_expense: ...". Also add a simple test to evaluate the feature you are fixing. Would you be so kind to review mine back? #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants