[18.0][FIX] Fix shipment advice function is_loaded_in_shipment

[TDu]

Finally fixing the broken function after the commit described below

Revert

• [18.0][FIX] shipment_advice: load package #200

It breaks the module shopfloor_delivery_shipment

Because this function

stock-logistics-transport/shipment_advice/models/stock_package_level.py

Line 43 in a1b8ac8

def _is_loaded_in_shipment(self):

relies on the is_done field. And it is not covered by tests 😞

Also there is a fix proposed on odoo for the root cause of the issue

• [FIX] stock: fix StockPackageLevel quantity split issue odoo/odoo#242487

[OCA-git-bot]

Hi @jbaudoux,
some modules you are maintaining are being modified, check this out!

[jbaudoux]

@TDu When the move line is marked as picked by the move line load_shipment, the package level is then also marked as is_done. However, I see the compute is_done is lacking a depends on move_line_ids.picked
https://github.com/odoo/odoo/blob/80a1f0e8208c52c8995ccf4ebb24db1bf8ead8a1/addons/stock/models/stock_package_level.py#L42

If we write also the current quantity when we mark as picked, will it trigger the compute is_done?
Otherwise, let's explicitly call the compute method.

This way, it will work without the patch on odoo. Also I prefer we don't rely on is_done if possible as this is dropped in odoo v19.

[TDu]

Added a unit test

[jbaudoux]

Suggested change

	all([line.picked for line in pl.move_line_ids])
	pl.move_line_ids and all([line.picked for line in pl.move_line_ids])

[jbaudoux]

@TDu Can't we just invalidate is_done on the corresponding package levels when we mark a move line as picked in the move line load shipment ?
You should then be able to rely on the package level is done which is more accurate as it ensures all corresponding move lines are there