[18.0][IMP] stock_vertical_lift: shared stock location for shuttles#2509
Open
[18.0][IMP] stock_vertical_lift: shared stock location for shuttles#2509
Conversation
vvrossem
force-pushed
the
18.0-imp-stock_vertical_lift-shuttle_shared_storage_location
branch
7 times, most recently
from
6dedbca to
439bfaf
Compare
vvrossem
force-pushed
the
18.0-imp-stock_vertical_lift-shuttle_shared_storage_location
branch
from
439bfaf to
d31d34f
Compare
SilvioC2C
approved these changes
Apr 2, 2026
Contributor
SilvioC2C
left a comment
SilvioC2C
left a comment
There was a problem hiding this comment.
Nice work, LGTM overall!
Comment on lines
38
to
+39
| recursive=True, | ||
| store=True, | ||
| store=False, |
Contributor
There was a problem hiding this comment.
2 quick (non blocking) comments:
- the
computemethod doesn't depend anymore on the location's parent valuelocation_id.vertical_lift_shuttle_id, butrecursive=Truewill still force Odoo to recompute this field on single records instead of a whole recordset (see https://github.com/odoo/odoo/blob/18.0/odoo/fields.py#L1455-L1463 and https://github.com/odoo/odoo/blob/18.0/odoo/fields.py#L1303-L1309), leading to worse performances overall => we can removerecursive=True - since we're moving from a stored to a non-stored field, could be nice to have a
searchmethod implemented here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.