[17.0][ADD] stock_lot_product_category: product category available on Lots#2520
Open
[17.0][ADD] stock_lot_product_category: product category available on Lots#2520
Conversation
dreispt
changed the title
| class StockLot(models.Model): | ||
| _inherit = "stock.lot" | ||
|
|
||
| product_category_id = fields.Many2one( |
Contributor
There was a problem hiding this comment.
@dreispt How does this behave on big databases ? Shouldn't we add a pre_init hook ?
carlossainznetkia
left a comment
carlossainznetkia
left a comment
There was a problem hiding this comment.
Looks good overall.
I agree with the comment: adding a stored related Many2one (product_category_id) can be expensive on large DBs at install/upgrade due to the backfill/recompute.
It’d be safer to add a pre_init_hook to populate it efficiently and avoid potential long installs/locks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.