Open
Conversation
MiquelRForgeFlow
force-pushed
the
19.0-add-stock_location_code
branch
2 times, most recently
from
90bbfaa to
a9f9527
Compare
Contributor
AaronHForgeFlow
left a comment
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
LGTM! some small suggestions:
while searching I would like to see the code as well:
Maybe we could add constraint unique code per company too.
MiquelRForgeFlow
force-pushed
the
19.0-add-stock_location_code
branch
from
a9f9527 to
cc26853
Compare
Contributor
Author
Done.
Sublocations could have same code, so I don't recommend this. |
MiquelRForgeFlow
force-pushed
the
19.0-add-stock_location_code
branch
from
cc26853 to
d79eacb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stock Location Code
This module adds a code field in the location.