[19.0][MIG] stock_putaway_product_template: Migration to 19.0#2530
Open
gdgellatly wants to merge 21 commits intoOCA:19.0from
Open
[19.0][MIG] stock_putaway_product_template: Migration to 19.0#2530gdgellatly wants to merge 21 commits intoOCA:19.0from
gdgellatly wants to merge 21 commits intoOCA:19.0from
Conversation
[UPD] Update stock_putaway_product_form.pot [UPD] README.rst
[UPD] Update stock_putaway_product_template.pot [UPD] README.rst
… you already set a product template TT34143 stock_putaway_product_template 13.0.1.1.0
[UPD] Update stock_putaway_product_template.pot
…tionCase stock_putaway_product_template 15.0.1.0.1 Translated using Weblate (Spanish) Currently translated at 100.0% (7 of 7 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_putaway_product_template Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_putaway_product_template/es/ [UPD] README.rst
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_putaway_product_template Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_putaway_product_template/es/
…in putaway rules. In this module, the product template, variant and category fields were made mandatory. Actually in relocation strategies it is not mandatory to set up a product, so the above mentioned fields should not be mandatory either. TT48457
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-18.0/stock-logistics-warehouse-18.0-stock_putaway_product_template Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-18-0/stock-logistics-warehouse-18-0-stock_putaway_product_template/es/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-18.0/stock-logistics-warehouse-18.0-stock_putaway_product_template Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-18-0/stock-logistics-warehouse-18-0-stock_putaway_product_template/it/
Fix singleton error calling _get_putaway_strategy on a recordset Fix tests
gdgellatly
force-pushed
the
19.0-mig-stock_putaway_product_template
branch
4 times, most recently
from
c237d89 to
180201b
Compare
gdgellatly
force-pushed
the
19.0-mig-stock_putaway_product_template
branch
from
180201b to
8a4a2b1
Compare
dannyadair
approved these changes
Mar 4, 2026
Contributor
dannyadair
left a comment
dannyadair
left a comment
There was a problem hiding this comment.
I've reviewed the code and functionality - looks good.
The .pot file is still referencing 18.0
Contributor
|
/ocabot migration stock_putaway_product_template |
rousseldenis
approved these changes
Mar 4, 2026
Contributor
|
This PR has the |
Author
|
@pedrobaeza Before this gets merged I want your opinion. I did change the overrride point because the filtered override did not work in v19 and it was confusing, however as I did it I was concerned that the original implementation was required for performance and whether that was the reason such efforts were gone to originally. |
Member
|
In fact it was @sergio-teruel the author of the module. Sergio, can you please check about the new method? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration of
stock_putaway_product_templatemodule to 19.0.filtered()override onstock.putaway.rulewith a cleaner_get_putaway_locationoverride that filters out template rules not matching the product before calling superstock_location.pyentirely (thefilter_putaway_rulecontext hack is no longer needed)product.categoryin tests sinceproduct_category_allwas removed in v19, which causedcateg_idto beFalseand the category domain to match all rules without a categoryTest plan
--test-enableon database with demo data