[FIX] stock_inventory_preparation_filter: exclude virtual locations from domain filter

[SaraMohamedlorim]

Problem

When using Filtered Products (domain) selection in Inventory Adjustment,
the results include quants from virtual locations (e.g. Customers, Inventory Adjustments),
which should not appear in a physical inventory count.

Fixes #2498

Root Cause

_get_quants() was searching quants by product_id only, without filtering
by location_id, causing virtual location quants to be included.

Solution

Added location_id filter to the quant search in _get_quants() when
product_selection == "domain", consistent with how other selection
modes handle location filtering.

Steps to Reproduce

1. Create an Inventory Adjustment
2. Set Filtered Products and define a domain (e.g. by category)
3. Click Begin Adjustment
4. ❌ Virtual location products appear in the results

After Fix

• ✅ Only quants from the selected location are returned
• ✅ Virtual locations (Customers, Inventory Adjustments, etc.) are excluded
• ✅ Test added to cover this scenario

[rousseldenis]

@SaraMohamedlorim Thanks for this.

You should follow this migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

You need to keep commits history

[nurinayati]

Hello @SaraMohamedlorim thank you for fixing this. I can not find the update on Runboat, could you follow the guide, please?

I would love to test and approve it. please let me know once you update and ready to test on Runboat. ;)

[SaraMohamedlorim]

@rousseldenis @nurinayati Thanks for the feedback. You're right — the same bug also exists on 16.0 and 18.0, so I've followed the OCA convention of fixing the oldest maintained branch first and forward-porting from there:

Opened a fix on 16.0 first: #[2604]
Cherry-picked that commit (with -x) into this branch, so the commit history is preserved and traceable back to the original fix: (cherry picked from commit 562e287)
I've just force-pushed the updated commit here, so this PR now has a single commit that keeps the history instead of a standalone rewrite. This should also trigger a fresh Runboat build.

Let me know if you'd like me to do the same for 18.0.

[nurinayati]

thank you @SaraMohamedlorim. Can we include the sublocations? It's missing for inventory adjustments
Please see example below I think the inventory adjustment should include the stock from WH/Stock/Shelf 2

Inventory Adjustment Current stock

WH/Stock: current stock including sublocations

[nurinayati]

Hi @rousseldenis, are there any other technical points to fix? Could you review again, please? thanks