[16.0][ADD] stock_picking_low_priority by glitchov · Pull Request #1196 · OCA/stock-logistics-workflow

glitchov · 2023-01-20T14:29:29Z

This module reintriduces a 'Not urgent' low priority on stock_picking/stock_move

lmignon · 2023-01-23T09:47:56Z

@@ -0,0 +1,2 @@
+* Nans Lefebvre <nans.lefebvre@acsone.eu>


@glitchov You can remove Nans from the author....

lmignon

@glitchov Thank you for this addon. Some comments but seems to be on the right track.

lmignon · 2023-01-23T12:47:28Z

@glitchov tests are failing

glitchov · 2023-01-23T13:10:40Z

I know. I've already changed a lot of things but they still fail on OCA but not locally...

lmignon · 2023-01-23T13:42:37Z

@glitchov ok I'll take a look

lmignon

Code review and functional tests

lmignon · 2023-01-23T16:24:56Z

ping @glitchov @rousseldenis @jbaudoux

rousseldenis

LGTM. Code review

jbaudoux

LGTM

OCA-git-bot · 2023-01-25T15:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2023-02-09T13:11:13Z

@glitchov

github-actions · 2023-06-11T12:33:01Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rousseldenis · 2023-06-12T06:58:39Z

@glitchov Could you fix tests ?

github-actions · 2023-10-22T12:31:08Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions · 2024-04-28T12:33:29Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rousseldenis · 2024-06-03T11:56:34Z

@jbaudoux I'll look at tests for this

jbaudoux

Can you move the changes to stock_move_priority_picking_assign in another PR as I don't see the link with the other new module

…rity through picking one

Signed-off-by LoisRForgeFlow

glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch from f404898 to 78956f9 Compare January 20, 2023 15:14

glitchov changed the title ~~[16.0][ADD] stock_picking_low_priotiy~~ [16.0][ADD] stock_picking_low_priority Jan 20, 2023

glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch 2 times, most recently from e30af06 to 5af1c70 Compare January 23, 2023 08:59

rousseldenis added the needs review label Jan 23, 2023

rousseldenis added this to the 16.0 milestone Jan 23, 2023

lmignon reviewed Jan 23, 2023

View reviewed changes

Comment thread stock_picking_low_priority/tests/test_stock_picking_low_priority.py Outdated

lmignon reviewed Jan 23, 2023

View reviewed changes

Comment thread stock_picking_low_priority/tests/test_stock_picking_low_priority.py Outdated

lmignon suggested changes Jan 23, 2023

View reviewed changes

glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch from 5af1c70 to 732ea00 Compare January 23, 2023 10:29

lmignon force-pushed the 16.0-add-stock_picking_low_priority-hda branch from abb08eb to d9e6c06 Compare January 23, 2023 16:18

lmignon approved these changes Jan 23, 2023

View reviewed changes

rousseldenis approved these changes Jan 24, 2023

View reviewed changes

OCA-git-bot added the approved label Jan 24, 2023

jbaudoux approved these changes Jan 24, 2023

View reviewed changes

OCA-git-bot added the ready to merge label Jan 25, 2023

rousseldenis reviewed Feb 9, 2023

View reviewed changes

Comment thread requirements.txt

glitchov force-pushed the 16.0-add-stock_picking_low_priority-hda branch from d9e6c06 to a3b368d Compare February 9, 2023 14:01

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 11, 2023

rousseldenis force-pushed the 16.0-add-stock_picking_low_priority-hda branch from a3b368d to ffaa42c Compare June 12, 2023 06:40

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 18, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 22, 2023

github-actions bot closed this Dec 3, 2023

jbaudoux reopened this Dec 3, 2023

dreispt added needs fixing and removed needs review stale PR/Issue without recent activity, it'll be soon closed automatically. labels Dec 27, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024

github-actions bot closed this Jun 2, 2024

jbaudoux added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jun 3, 2024

jbaudoux reopened this Jun 3, 2024

[16.0][ADD] stock_picking_low_priotiy

7586a22

rousseldenis force-pushed the 16.0-add-stock_picking_low_priority-hda branch 2 times, most recently from e0c34ed to 842b189 Compare June 4, 2024 09:55

jbaudoux reviewed Jun 12, 2024

View reviewed changes

Comment thread stock_move_priority_picking_assign/models/stock_picking.py

rousseldenis force-pushed the 16.0-add-stock_picking_low_priority-hda branch from 842b189 to 7586a22 Compare September 24, 2024 06:57

[IMP] stock_move_priority_picking_assign: Allows to modify moves prio…

c6c1307

…rity through picking one

giarve pushed a commit to wvbs/stock-logistics-workflow that referenced this pull request Dec 20, 2024

Merge PR OCA#1196 into 16.0

c1fe142

Signed-off-by LoisRForgeFlow

Uh oh!

Conversation

glitchov commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmignon Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lmignon left a comment

Choose a reason for hiding this comment

Uh oh!

lmignon commented Jan 23, 2023

Uh oh!

glitchov commented Jan 23, 2023

Uh oh!

lmignon commented Jan 23, 2023

Uh oh!

lmignon left a comment

Choose a reason for hiding this comment

Uh oh!

lmignon commented Jan 23, 2023

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jan 25, 2023

Uh oh!

Uh oh!

rousseldenis commented Feb 9, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

rousseldenis commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 22, 2023

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

rousseldenis commented Jun 3, 2024

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

glitchov commented Jan 20, 2023 •

edited

Loading

rousseldenis commented Jun 12, 2023 •

edited

Loading