Conversation
5996980 to
d49ebcc
Compare
|
/ocabot migration stock_move_backdating |
4eb6454 to
361ac67
Compare
|
@Saran440 Could you fix pre-commit and enhance your commit messages ? Thanks |
|
I've made a pull to fix the pre-commit errors ecosoft-odoo#2 |
f7200b3 to
ca8e33d
Compare
|
@alessandro-fiorino Thank you for your contribution. |
|
It fails some test. I think the problem is in the test itself https://github.com/ecosoft-odoo/stock-logistics-workflow/blob/ca8e33d35f67f5716e349230eda9285074873212/stock_move_backdating/tests/common.py#L66 |
|
Updated:
|
arielbarreiros96
left a comment
There was a problem hiding this comment.
I've reviewed if from a functional perspective and it looks good, I tested mainly the backdating at the moment of making inventory adjustments. I do think the Readme file could include a Usage section, I literally had to read the code to know what to do.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@arielbarreiros96 Is this one ok for you now? Can you update your review? |
|
@arielbarreiros96 I updated the README. Can you check it? |
1ee527b to
7378d60
Compare
|
@Saran440 Can you fix this one? |
|
@bosd it error from module I never use this module. So, i can't fixed it. |
|
v18 migration in stock_move_backdating #1921 |
bosd
left a comment
There was a problem hiding this comment.
While working on the v18 migration I noticed some unit tests are disabled and needs fixing. (Fixes are applied in V18 migration)
The issue is solely with the unit tests. The module itself is working perfectly. 👍
Thanks for the update. Checked README after edits, seems much better now, simple and pretty straight forward👌 |
Currently translated at 95.4% (21 of 22 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Currently translated at 95.4% (21 of 22 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Currently translated at 100.0% (22 of 22 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/
Currently translated at 100.0% (22 of 22 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Currently translated at 100.0% (22 of 22 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
adc6d3e to
4bfea2d
Compare
|
Fixed error test script. @map-240221 @bosd Could you check please? and cherry-pick commit 4bfea2d to version17, 18 |
|
Works fine here, added to the version 17 migration. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
Can we get a merge? |
|
Not an expert, guys. But do you need any help to make codecov work? |
|
@pere-aquarian Thanks for your notice. However, I think v16 is outdated for updating the test scripts. This should be improved in the newer version. |

This PR migrated from version15 and enhance to supported backdate scrap