Skip to content

[17.0][MIG] stock_quant_package_dimension#1622

Merged
OCA-git-bot merged 48 commits intoOCA:17.0from
Studio73:17.0-mig-stock_quant_package_dimension
Dec 9, 2024
Merged

[17.0][MIG] stock_quant_package_dimension#1622
OCA-git-bot merged 48 commits intoOCA:17.0from
Studio73:17.0-mig-stock_quant_package_dimension

Conversation

@ferran-S73
Copy link
Contributor

@ferran-S73 ferran-S73 commented Jun 11, 2024

@ferran-S73 ferran-S73 mentioned this pull request Jun 11, 2024
75 tasks
@ferran-S73 ferran-S73 force-pushed the 17.0-mig-stock_quant_package_dimension branch from 0371252 to 64dde88 Compare June 12, 2024 06:53
@ferran-S73 ferran-S73 force-pushed the 17.0-mig-stock_quant_package_dimension branch from 64dde88 to 64fb8a1 Compare June 12, 2024 07:18
@@ -0,0 +1,2 @@
This module adds dimension fields on stock packages and an estimated
weight (in kg).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add the file USAGE.rst to the description settings and workflow.

@ferran-S73 ferran-S73 force-pushed the 17.0-mig-stock_quant_package_dimension branch from 64fb8a1 to 423ecfc Compare July 23, 2024 14:31
Copy link

@traitrantrobz traitrantrobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented Dec 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
@ferran-S73
Copy link
Contributor Author

@OCA/logistics-maintainers

@rousseldenis
Copy link
Contributor

/ocabot migration stock_quant_package_dimension

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 2, 2024
@ferran-S73 ferran-S73 force-pushed the 17.0-mig-stock_quant_package_dimension branch from 423ecfc to 39c1381 Compare December 3, 2024 14:34
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 8, 2024
grindtildeath and others added 12 commits December 9, 2024 12:34
When a packaging is auto-assigned on a package, it should not
override any previously set dimensions.

When

* if a user changes the packaging from the UI, all the dimensions are
  overridden from the packaging (even if they are zero) which match the
  general behavior of onchanges
* if the packaging is changed through the "auto assign" mechanism
  (_auto_assign_packaging in context), only the package fields != 0 are
  set from the packaging, as we don't want to silently erase previously
  set dimensions

In the second case, the packaging dimensions act as "default values" for
the dimensions. Example: an hardware scale sets the weight, the other
dimensions (width, height, ...) are completed from the packaging).
rousseldenis and others added 11 commits December 9, 2024 12:34
…efault

As the original field is a computed one with a default, Odoo generates
warning about that default if defined on a related field.

So, override the compute method instead.
Currently translated at 58.3% (14 of 24 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/it/
Currently translated at 58.3% (14 of 24 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/it/
Currently translated at 100.0% (24 of 24 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/
Currently translated at 100.0% (24 of 24 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/it/
Currently translated at 100.0% (24 of 24 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/es/
Currently translated at 100.0% (24 of 24 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/it/
Currently translated at 100.0% (24 of 24 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_quant_package_dimension
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_quant_package_dimension/it/
@ferran-S73 ferran-S73 force-pushed the 17.0-mig-stock_quant_package_dimension branch from 39c1381 to f67b9d9 Compare December 9, 2024 11:34
@ferran-S73
Copy link
Contributor Author

@jbaudoux can you merge please?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux
Copy link
Contributor

jbaudoux commented Dec 9, 2024

@jbaudoux can you merge please?

You need to rewrite commit msg for
[IMP] stock_quant_package_dimension
into
[IMP] stock_quant_package_dimension: pre-commit auto fixes

@ferran-S73 ferran-S73 force-pushed the 17.0-mig-stock_quant_package_dimension branch from f67b9d9 to bd900f9 Compare December 9, 2024 11:55
@ferran-S73
Copy link
Contributor Author

@jbaudoux can you merge please?

You need to rewrite commit msg for [IMP] stock_quant_package_dimension into [IMP] stock_quant_package_dimension: pre-commit auto fixes

@jbaudoux done

@jbaudoux
Copy link
Contributor

jbaudoux commented Dec 9, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1622-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 138f23c into OCA:17.0 Dec 9, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8f46a4f. Thanks a lot for contributing to OCA. ❤️

@ferran-S73 ferran-S73 deleted the 17.0-mig-stock_quant_package_dimension branch December 9, 2024 12:36
Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.