[ADD] stock_picking_putaway_recompute#1740
Conversation
rousseldenis
force-pushed
the
16.0-add-stock-picking-putaway-recompute-dro
branch
2 times, most recently
from
e5ed3ee to
43043bc
Compare
rousseldenis
force-pushed
the
16.0-add-stock-picking-putaway-recompute-dro
branch
2 times, most recently
from
525e51d to
84d7ec0
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
jbaudoux
added
no stale
… packages As soon as there is a result package for the operation, the destination location recomputation is not authorized as all operations contained in a package should go to the same destination.
…on location This is more correct as the original location before applying the putaways is the stock move destination location.
rousseldenis
force-pushed
the
16.0-add-stock-picking-putaway-recompute-dro
branch
from
84d7ec0 to
db3c2d9
Compare
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
| from odoo.fields import Command, first | ||
|
|
||
| from odoo.addons.base.tests.common import BaseCommon |
There was a problem hiding this comment.
BaseCommon does too many things and it slows down setup. If you don't need company, currency, user, etc, use TransactionCase + tracking_disable or DISABLED_MAIL_CONTEXT.
| return self.filtered( | ||
| lambda line: line.picking_type_id.allow_to_recompute_putaways |
There was a problem hiding this comment.
Wouldn't it make more sense to have the filtering function defined at line level instead of one that filters out without the ability to override?
| help="Technical field in order to display the Recompute Putaways button.", | ||
| ) | ||
|
|
||
| def action_recompute_putaways(self) -> dict: |
There was a problem hiding this comment.
I don't know much about annotations but AFAIU this function must return a dict but doesn't return anything
|
@rousseldenis I did the suggested changes here to speed up the merge of that PR: acsone#2 Can you please check and merge if that's good for you? 🙏 |
… dependencies Recomputation was allowed at picking level even if it was not allowed on the picking type. Make sure the computation on stock.move.line reuses the conditions defined at picking level.
lmignon
force-pushed
the
16.0-add-stock-picking-putaway-recompute-dro
branch
from
84ab41a to
16d3568
Compare
done 😏 |
5 participants
No description provided.