Skip to content

[16.0][ADD] purchase_stock_price_variance#1893

Open
AungKoKoLin1997 wants to merge 1 commit intoOCA:16.0from
qrtl:16.0-add-purchase_stock_price_variance
Open

[16.0][ADD] purchase_stock_price_variance#1893
AungKoKoLin1997 wants to merge 1 commit intoOCA:16.0from
qrtl:16.0-add-purchase_stock_price_variance

Conversation

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Mar 5, 2025

This module checks the variance between the purchase price and the product's standard price at the time of receipt picking validation. If the variance exceeds a given threshold, the notification can be left in the chatter. Additionally, an error can be triggered before receiving the stock if needed.

@qrtl QT4947

@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Mar 11, 2025
Closed
nobuQuartile
nobuQuartile approved these changes Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code review and Functional review

yostashiro
yostashiro approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very minor non-blocking points. LGTM.

Comment thread purchase_stock_price_variance/tests/test_purchase_stock_price_variance.py Outdated
Comment thread purchase_stock_price_variance/tests/test_purchase_stock_price_variance.py
Comment thread purchase_stock_price_variance/security/purchase_stock_price_variance_security.xml Outdated
Comment thread purchase_stock_price_variance/readme/CONFIGURE.md Outdated
Comment thread purchase_stock_price_variance/readme/CONFIGURE.md Outdated
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 12, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-purchase_stock_price_variance branch 3 times, most recently from 3ed70a7 to 8469f13 Compare March 13, 2025 08:29
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-purchase_stock_price_variance branch from 8469f13 to 19dff71 Compare May 27, 2025 07:43
@AungKoKoLin1997
Copy link
Copy Markdown
Contributor Author

AungKoKoLin1997 commented May 27, 2025

@oca/stock-logistics-workflow-maintainers
Is it possible to look at this PR?

@rousseldenis rousseldenis added this to the 16.0 milestone May 27, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-purchase_stock_price_variance branch from 19dff71 to c2d54ea Compare July 11, 2025 02:22
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 9, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-purchase_stock_price_variance branch from c2d54ea to 65b3676 Compare November 10, 2025 01:26
kanda999
kanda999 approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: it works as expected

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 22, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 22, 2026
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-purchase_stock_price_variance branch from 65b3676 to d2bedf1 Compare April 6, 2026 03:40
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@yostashiro yostashiro yostashiro approved these changes

@kanda999 kanda999 kanda999 approved these changes

@nobuQuartile nobuQuartile nobuQuartile approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

6 participants

@AungKoKoLin1997 @OCA-git-bot @yostashiro @kanda999 @nobuQuartile @rousseldenis