[16.0][ADD] stock_picking_move_line_no_print: new module#1967
[16.0][ADD] stock_picking_move_line_no_print: new module#1967chienandalu wants to merge 1 commit intoOCA:16.0from
Conversation
c3e7abf to
fe55e9b
Compare
808788f to
85c356d
Compare
85c356d to
238d176
Compare
238d176 to
ab3ca33
Compare
|
Sorry @yajo you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
/ocabot rebase |
|
@rafaelbn The rebase process failed, because command |
Gelojr
left a comment
There was a problem hiding this comment.
Review status: Not OK. A revision is required.
Reason: After disabling “Display in report” on a move, saving, and then confirming the picking, the printed delivery slip still includes that line; it should be hidden, so the printing logic is not honoring the flag once the picking is confirmed.
The following tests were executed.
- Test 1: Hide a move from delivery slip — Steps: disable “Display in report” on one move, save, confirm the picking, print delivery slip — Result: NOT OK; the hidden move is still printed — Expected: the move should not appear in the report.
- No additional tests were run until this issue is resolved.
|
@Gelojr the report you show in the screenshot isn't the delivery slip but the internal operations one which logically must show the lines normally |
|
I'll check it again
El mié, 24 sept 2025 a las 9:21, David Vidal ***@***.***>)
escribió:
… *chienandalu* left a comment (OCA/stock-logistics-workflow#1967)
<#1967 (comment)>
@Gelojr <https://github.com/Gelojr> the report you show in the screenshot
isn't the delivery slip but the internal operations one which logically
must show the lines normally
—
Reply to this email directly, view it on GitHub
<#1967 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDFUBLSVNIHQUGTK3HOI4QL3UJA57AVCNFSM6AAAAAB6CHE4JKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMRWHE2DKNZXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Thank you for your excellent work and contribution, @chienandalu, but the review status is incorrect.
Reason:
I'm not sure if the result of test 3 is as expected.
The result of test 4 is incorrect. After validation, the printed delivery note does not respect the 'Show in report' checkbox; a line is printed whose checkbox is not selected.
The following tests have been performed:
- Test 1: Hide a movement with detailed operations enabled. Result: correct.
- Test 2: Change visibility and reprint with Detailed Operations enabled. Result: Correct (the second printout excludes the unchecked movement, as expected).
- Test 3: Not sure if it's correct
- I add 3units of product A to line 1.
- Then I add product B to line 2, also with 3 units. Uncheck Display in report
- Then I add the same product, B, to line 3, but this time with 2 units.
- I save. When I print, prints line 1 (3 units) and line 3 (2 units)
- If valid, products B on lines 2 and 3 are grouped and printed together as 5 units on a single line. Result: I don't know if this is the expected behaviour.
- Test 4: Result: Incorrect.
- Create a delivery with three products.
- Set the delivered quantity for line 1 = 0 units with 'Show in report' checked.
- The delivered quantity for line 2 = 3 units with 'Show in report' unchecked.
- The delivered quantity for line 3 = 5 units with 'Show in report' checked.
- Save and print: only line 3 is printed (correct).
- Validate and print again: lines 2 and 3 are printed. However, line 2 should not be printed because its indicator is not checked.
ab3ca33 to
a21c7d4
Compare
@chienandalu could you please attend the review? Tests are ❌ too. Thanks. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
cc @moduon @rafaelbn @yajo MT-9255