Skip to content

[18.0][MIG] stock_account_fifo_return_origin: Migration to 18.0#2255

Open
AungKoKoLin1997 wants to merge 2 commits intoOCA:18.0from
qrtl:18.0-mig-stock_account_fifo_return_origin
Open

[18.0][MIG] stock_account_fifo_return_origin: Migration to 18.0#2255
AungKoKoLin1997 wants to merge 2 commits intoOCA:18.0from
qrtl:18.0-mig-stock_account_fifo_return_origin

Conversation

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Feb 16, 2026 •
edited
Loading

Depends on #1649

@qrtl QT6408

yostashiro
yostashiro approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-stock_account_fifo_return_origin branch from 1c2d504 to 60ac1bd Compare February 19, 2026 02:01
@AungKoKoLin1997
Copy link
Copy Markdown
Contributor Author

AungKoKoLin1997 commented Feb 19, 2026

@yostashiro I just added a new test case for _create_correction_svl for educing the quantity after the receipt is validated.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-stock_account_fifo_return_origin branch from 60ac1bd to 3d578dd Compare February 19, 2026 02:38
@AungKoKoLin1997
Copy link
Copy Markdown
Contributor Author

AungKoKoLin1997 commented Feb 19, 2026

@yostashiro
I just realized backorder will be created for each move with the previous approach of calling super() in action_done for each move.
So, I decided to extend _get_out_svl_vals() instead of action_done().

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-stock_account_fifo_return_origin branch from 3d578dd to caf123b Compare February 24, 2026 07:12
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-stock_account_fifo_return_origin branch from caf123b to 8fc1c9d Compare March 11, 2026 01:42
kanda999
kanda999 approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

yostashiro
yostashiro approved these changes Mar 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-stock_account_fifo_return_origin branch from 8fc1c9d to dc3baaa Compare March 18, 2026 06:30
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 18, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BhaveshHeliconia
BhaveshHeliconia approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@yostashiro yostashiro yostashiro approved these changes

@kanda999 kanda999 kanda999 approved these changes

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AungKoKoLin1997 @OCA-git-bot @yostashiro @kanda999 @BhaveshHeliconia