[17.0][MIG] survey_certification_py3o: Migration to version 17.0#173
Conversation
|
/ocabot migration survey_certification_py3o |
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
When a user tries to print a report but the survey doesn't have a template, I get this error.
Could we handle the error and raise a UserError instead of showing a traceback?
Additionally, please squash the administrative commits.
This is a error handled in the report_py3o module. The priority of this module is to send the custom report in case of a defined template. Manual printing offers the possibility of downloading it from the backend by someone in charge to provide a copy or send it outside of odoo, although this should not be the usual flow. |
pilarvargas-tecnativa
force-pushed
the
17.0-mig-survey_certification_py3o
branch
from
62b3f71 to
4dc39ac
Compare
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
This is a error handled in the report_py3o module. The priority of this module is to send the custom report in case of a defined template. Manual printing offers the possibility of downloading it from the backend by someone in charge to provide a copy or send it outside of odoo, although this should not be the usual flow.
OK, I understand. Although I’d prefer to get a more user-friendly error instead of a traceback, but anyway, let’s go.
| if model_instance._name == "survey.survey": | ||
| if ( | ||
| model_instance._name == "survey.user_input" | ||
| and model_instance.py3o_template_id |
There was a problem hiding this comment.
Wasn't this model_instance.survey_id.py3o_template_id?
There was a problem hiding this comment.
https://github.com/OCA/survey/blob/15.0/survey_certification_py3o/models/survey_user_input.py#L9
The template is set at survey level but the related of survey.user_input is checked.
v15: https://github.com/OCA/survey/blob/15.0/survey_certification_py3o/models/py3o_report.py#L12-L15
pilarvargas-tecnativa
force-pushed
the
17.0-mig-survey_certification_py3o
branch
from
4dc39ac to
d009da1
Compare
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 4c180de. Thanks a lot for contributing to OCA. ❤️ |
5 participants
@Tecnativa TT56326
@carlos-lopez-tecnativa @victoralmau please review